Skip to content

Cherrypick [BEAM-14014] Support impersonation credentials in dataflow runner (#17244) - #17668

Merged
y1chi merged 1 commit into
apache:release-2.39.0from
y1chi:release-2.39.0
May 13, 2022
Merged

Cherrypick [BEAM-14014] Support impersonation credentials in dataflow runner (#17244)#17668
y1chi merged 1 commit into
apache:release-2.39.0from
y1chi:release-2.39.0

Conversation

@y1chi

@y1chiy1chi commented May 13, 2022

Copy link
Copy Markdown

Cherrypicks #17244


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@y1chi

Copy link
Copy Markdown
Author

Run Python 3.8 PostCommit

@codecov

codecovBot commented May 13, 2022

Copy link
Copy Markdown

Codecov Report

Merging #17668 (0ebd7c5) into release-2.39.0 (a83cb6a) will increase coverage by 0.03%.
The diff coverage is 78.00%.

@@ Coverage Diff @@## release-2.39.0 #17668 +/- ##
==================================================
+ Coverage 73.83% 73.86% +0.03% 
==================================================
Files 691 691 Lines 91249 91557 +308 ==================================================
+ Hits 67371 67631 +260 - Misses 22650 22698 +48 
Partials 1228 1228 
FlagCoverage Δ
python83.68% <78.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
sdks/python/apache_beam/io/gcp/bigquery_tools.py83.15% <ø> (+0.17%)⬆️
...ks/python/apache_beam/runners/interactive/utils.py95.41% <ø> (ø)
..._beam/runners/portability/sdk_container_builder.py37.93% <0.00%> (ø)
...apache_beam/runners/dataflow/internal/apiclient.py77.39% <50.00%> (+0.03%)⬆️
sdks/python/apache_beam/internal/gcp/auth.py78.66% <76.92%> (-2.37%)⬇️
sdks/python/apache_beam/io/gcp/gcsfilesystem.py88.65% <82.35%> (+0.41%)⬆️
sdks/python/apache_beam/io/gcp/gcsio.py92.26% <100.00%> (ø)
...dks/python/apache_beam/options/pipeline_options.py94.93% <100.00%> (+0.01%)⬆️
sdks/python/apache_beam/coders/row_coder.py94.49% <0.00%> (-2.65%)⬇️
sdks/python/apache_beam/runners/common.py87.94% <0.00%> (-2.33%)⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83cb6a...0ebd7c5. Read the comment docs.

@y1chi
y1chi merged commit 10aeab8 into apache:release-2.39.0May 13, 2022
@kennknowleskennknowles changed the title Cherrypick [BEAM-14014] Support impersonation credentials in dataflow runner (#1…Cherrypick [BEAM-14014] Support impersonation credentials in dataflow runner (#17244)May 3, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@y1chi@ryanthompson591