Skip to content

Update google-cloud-bigquery-storage to require 2.11.0 or later - #17686

Closed
kmjung wants to merge 1 commit into
apache:masterfrom
kmjung:bigquery_storage_client
Closed

Update google-cloud-bigquery-storage to require 2.11.0 or later#17686
kmjung wants to merge 1 commit into
apache:masterfrom
kmjung:bigquery_storage_client

Conversation

@kmjung

Copy link
Copy Markdown
Contributor

This change updates the dependency requirements for the google-cloud-bigquery-storage library to require version 2.11 or later in order to pick up googleapis/python-bigquery-storage#366.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci

Copy link
Copy Markdown

Can one of the admins verify this patch?

1 similar comment
@asf-ci

Copy link
Copy Markdown

Can one of the admins verify this patch?

@chamikaramjchamikaramj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@chamikaramj

Copy link
Copy Markdown
Contributor

Run Python 3.8 PostCommit

@chamikaramj

Copy link
Copy Markdown
Contributor

Ah, actually you also need to run following.
./gradlew :sdks:python:container:generatePythonRequirementsAll

See: https://github.com/apache/beam/blob/master/sdks/python/container/py38/base_image_requirements.txt#L17

@codecov

codecovBot commented May 16, 2022

Copy link
Copy Markdown

Codecov Report

Merging #17686 (a1d51d4) into master (03c3c36) will increase coverage by 1.40%.
Report is 4078 commits behind head on master.
The diff coverage is n/a.

@@ Coverage Diff @@## master #17686 +/- ##
==========================================
+ Coverage 74.00% 75.41% +1.40% 
==========================================
Files 695 702 +7 Lines 91798 100144 +8346 ==========================================
+ Hits 67939 75520 +7581 - Misses 22611 23376 +765 
Partials 1248 1248 
FlagCoverage Δ
python84.56% <ø> (+0.80%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 87 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaltay

Copy link
Copy Markdown
Member

What is the next step on this PR?

@aaltay

Copy link
Copy Markdown
Member

Could this be merged?

@aaltay

Copy link
Copy Markdown
Member

Run Python PreCommit

@aaltay

Copy link
Copy Markdown
Member

It seems like tests are failing. I can trigger once again.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actionsgithub-actionsBot added stale and removed stale labels Jun 16, 2023
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actionsgithub-actionsBot added stale and removed stale labels Aug 16, 2023
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kmjung@asf-ci@chamikaramj@aaltay