Skip to content

[BEAM-14517] Add files_to_stage option to Python SDK - #17765

Closed
ihji wants to merge 1 commit into
apache:masterfrom
ihji:BEAM-14517
Closed

[BEAM-14517] Add files_to_stage option to Python SDK#17765
ihji wants to merge 1 commit into
apache:masterfrom
ihji:BEAM-14517

Conversation

@ihji

@ihjiihji commented May 26, 2022

Copy link
Copy Markdown
Contributor

Adding files_to_stage option. Basically it does the same thing with jar_packages option but for all types of files.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov

codecovBot commented May 26, 2022

Copy link
Copy Markdown

Codecov Report

Merging #17765 (f2470de) into master (5bb3127) will increase coverage by 0.00%.
The diff coverage is 95.23%.

@@ Coverage Diff @@## master #17765 +/- ##
=======================================
Coverage 74.01% 74.01% =======================================
Files 695 695 Lines 91798 91814 +16 =======================================
+ Hits 67941 67954 +13 - Misses 22611 22614 +3 
Partials 1246 1246 
FlagCoverage Δ
python83.75% <95.23%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
...s/python/apache_beam/runners/portability/stager.py85.50% <95.00%> (-0.04%)⬇️
...dks/python/apache_beam/options/pipeline_options.py94.94% <100.00%> (+0.01%)⬆️
...python/apache_beam/runners/worker/worker_status.py78.26% <0.00%> (-1.45%)⬇️
...eam/runners/portability/fn_api_runner/execution.py92.44% <0.00%> (-0.65%)⬇️
sdks/python/apache_beam/transforms/combiners.py93.05% <0.00%> (-0.39%)⬇️
...ks/python/apache_beam/runners/worker/operations.py74.02% <0.00%> (-0.07%)⬇️
...hon/apache_beam/runners/worker/bundle_processor.py93.54% <0.00%> (-0.01%)⬇️
sdks/python/apache_beam/io/textio.py96.89% <0.00%> (ø)
...s/python/apache_beam/io/gcp/pubsublite/external.py0.00% <0.00%> (ø)
.../python/apache_beam/io/gcp/pubsublite/proto_api.py0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb3127...f2470de. Read the comment docs.

@ihji

ihji commented May 26, 2022

Copy link
Copy Markdown
ContributorAuthor

R: @chamikaramj

@aaltay
aaltay requested a review from chamikaramjJune 9, 2022 20:57
@ihji

ihji commented Jun 9, 2022

Copy link
Copy Markdown
ContributorAuthor

superseded by #21782

@ihjiihji closed this Jun 9, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ihji