Skip to content

[BEAM-13829] Enable worker status in Go - #17768

Merged
lostluck merged 1 commit into
apache:masterfrom
riteshghorse:beam-13829
May 26, 2022
Merged

[BEAM-13829] Enable worker status in Go#17768
lostluck merged 1 commit into
apache:masterfrom
riteshghorse:beam-13829

Conversation

@riteshghorse

Copy link
Copy Markdown
Contributor

Enable worker status support from Go. Added in #16957


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci

Copy link
Copy Markdown

Can one of the admins verify this patch?

1 similar comment
@asf-ci

Copy link
Copy Markdown

Can one of the admins verify this patch?

@codecov

codecovBot commented May 26, 2022

Copy link
Copy Markdown

Codecov Report

Merging #17768 (282e74a) into master (ff39fcb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #17768 +/- ##
=======================================
Coverage 74.00% 74.00% =======================================
Files 695 695 Lines 91841 91842 +1 =======================================
+ Hits 67965 67966 +1 
Misses 22630 22630 Partials 1246 1246 
FlagCoverage Δ
go50.46% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
sdks/go/pkg/beam/core/runtime/graphx/translate.go43.13% <100.00%> (+0.05%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff39fcb...282e74a. Read the comment docs.

@lostlucklostluck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@lostluck
lostluck merged commit 9a67e30 into apache:masterMay 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@riteshghorse@asf-ci@lostluck