Uh oh!
There was an error while loading. Please reload this page.
[BEAM-14347] Update docs to prefer generic registration functions - #17799
Conversation
asf-ci
commented
Jun 1, 2022
Can one of the admins verify this patch? |
2 similar comments
asf-ci
commented
Jun 1, 2022
Can one of the admins verify this patch? |
asf-ci
commented
Jun 1, 2022
Can one of the admins verify this patch? |
…damccorm/registration-docs-2
Assigning reviewers. If you would like to opt out of this review, comment R: @youngoli for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
commented
Jun 15, 2022
R: @lostluck |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
damccorm
commented
Jun 17, 2022
Thanks for the feedback, should be fixed. I think I wrote these before I introduced register.FunctionXxY, and forgot about that class of updates - thanks for calling it out! |
lostluck
left a comment
There was a problem hiding this comment.
One tiny change, but otherwise LGTM.
Uh oh!
There was an error while loading. Please reload this page.
Now that we've proven out the effectiveness of the generic registration functions in #17613 and the 2.40 release is upon us, we should update the docs to recommend that approach.
✨ RENDERED ✨
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.