Uh oh!
There was an error while loading. Please reload this page.
Fix Hadoop Downloader Range not correct - #21778
Merged
Merged
Conversation
* This fixes ValueError happens when reading a hdfs of file size larger than buffer size * Added related unit test
asf-ci
commented
Jun 9, 2022
Can one of the admins verify this patch? |
1 similar comment
asf-ci
commented
Jun 9, 2022
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@## master #21778 +/- ##
==========================================
+ Coverage 74.03% 74.43% +0.40%
==========================================
Files 698 699 +1 Lines 92192 93717 +1525 ==========================================
+ Hits 68252 69756 +1504 - Misses 22689 22710 +21
Partials 1251 1251
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Abacn
commented
Jun 9, 2022
ContributorAuthor
retest this please |
Abacn
marked this pull request as ready for review
June 9, 2022 21:46
Abacn
commented
Jun 9, 2022
ContributorAuthor
R: @chamikaramj |
Abacn
commented
Jun 10, 2022
ContributorAuthor
retest this please |
chamikaramj
commented
Jun 10, 2022
Contributor
Thanks for the quick fix. I can merge when tests pass. |
chamikaramj
commented
Jun 10, 2022
Contributor
Run Python PreCommit |
Abacn
commented
Jun 13, 2022
ContributorAuthor
Run RAT PreCommit |
Abacn
commented
Jun 13, 2022
ContributorAuthor
Run Python PreCommit |
1 similar comment
Abacn
commented
Jun 14, 2022
ContributorAuthor
Run Python PreCommit |
bullet03 pushed a commit
to akvelon/beam
that referenced
this pull request
Jun 20, 2022
* Fix Hadoop Downloader Range not correct * This fixes ValueError happens when reading a hdfs of file size larger than buffer size * Added related unit test * fix typo in comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes#20110
This fixes ValueError happens when reading a hdfs of file size larger than buffer size
Added related unit test
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.