Uh oh!
There was an error while loading. Please reload this page.
Add DirtyBit to represent whether Counters have been committed. - #219
Closed
peihe wants to merge 6 commits into
Closed
Add DirtyBit to represent whether Counters have been committed.#219peihe wants to merge 6 commits into
peihe wants to merge 6 commits into
Conversation
peihe
commented
Apr 20, 2016
ContributorAuthor
R: @bjchambers |
| * committing() None COMMITTING None | ||
| * committed() None None COMMITTED | ||
| */ | ||
| @VisibleForTesting |
Member
There was a problem hiding this comment.
DirtyBit suggest a bool, which this is explicitly not. CommitState?
tgroh
commented
Apr 20, 2016
Member
LGTM |
| @Nullable | ||
| public abstract CounterMean<T> getMean(); | ||
| /** |
Contributor
There was a problem hiding this comment.
/**
* Represents ...
(No need to say CommitState)
peihe
commented
Apr 25, 2016
ContributorAuthor
PTAL |
| /** | ||
| * Returns if the counter contains non-committed aggregate. | ||
| * | ||
| * <p>After all possible mutations have completed, the reader should check |
Contributor
There was a problem hiding this comment.
This looks great. Can you put the details of this counter lifecycle/contract in the Counter class javadoc?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.