Uh oh!
There was an error while loading. Please reload this page.
[#21634] Add comments on FieldValueGetter. - #21982
Conversation
| /** Return the size of data fields. */ | ||
| public abstract int getFieldCount(); | ||
| /** Return the list of data values. */ |
There was a problem hiding this comment.
Could you clarify the meaning of "raw" here?
There was a problem hiding this comment.
I've updated the comment @TheNeuralBit. For context, here's @reuvenlax's explanation of getValues.
From that it sounds like this shouldn't be publicly consumed and should also be annotated with @Internal.
getValues() is maybe poorly named - might be better called getRawValues. What you're looking for is probably the getBaseValues() method.
getValues is mostly used in code that knows exactly what it's doing for optimization purposes. It goes along with the attachValues method, which is similarly tricky to use. It's there to enable 0-copy code, but not necessarily intended for general consumption.
Follow up on #17172, adding some missing comments.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.