Skip to content

Followup sharding javaPostCommit - #22081

Merged
damccorm merged 2 commits into
apache:masterfrom
Abacn:shardfollowup
Jun 28, 2022
Merged

Followup sharding javaPostCommit#22081
damccorm merged 2 commits into
apache:masterfrom
Abacn:shardfollowup

Conversation

@Abacn

Copy link
Copy Markdown
Contributor

Follow up of #21800

  • Remove integration test depsOn that already sharded

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

* Remove integration test depsOn that already sharded
@asf-ci

Copy link
Copy Markdown

Can one of the admins verify this patch?

4 similar comments
@asf-ci

Copy link
Copy Markdown

Can one of the admins verify this patch?

@asf-ci

Copy link
Copy Markdown

Can one of the admins verify this patch?

@asf-ci

Copy link
Copy Markdown

Can one of the admins verify this patch?

@asf-ci

Copy link
Copy Markdown

Can one of the admins verify this patch?

@Abacn

Copy link
Copy Markdown
ContributorAuthor

Run Java PostCommit

@Abacn

Copy link
Copy Markdown
ContributorAuthor

postcommit due to IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry. Not sure the cause

@Abacn

Copy link
Copy Markdown
ContributorAuthor

Run Java PostCommit

@Abacn

Copy link
Copy Markdown
ContributorAuthor

@fernando-wizeline @benWize Jobs created in #21800 and #21804 have file name prefix and templates from PreCommit. But should these be PostCommit ? Also .test-infra/jenkins/README.md needs update

@benEng

Copy link
Copy Markdown
Contributor

@fernando-wizeline @benWize Jobs created in #21800 and #21804 have file name prefix and templates from PreCommit. But should these be PostCommit ? Also .test-infra/jenkins/README.md needs update

@Abacn here is a discussion about it #21808 (comment)

@Abacn

Copy link
Copy Markdown
ContributorAuthor

Thanks for pinning the context. Then I will update the readme to includes this tests in precommit section.

@Abacn

Copy link
Copy Markdown
ContributorAuthor

beam_PreCommit_Java_GCP_IO_Direct links not working yet. Likely need to run seed job. Otherwise ready for review

@Abacn

Copy link
Copy Markdown
ContributorAuthor

R: @benWize
R: @fernando-wizeline

@fernando-wizeline

Copy link
Copy Markdown
Contributor

LGTM.
Thanks for the help @Abacn!

@benEng

Copy link
Copy Markdown
Contributor

LGTM. Thanks, @Abacn

@Abacn

Copy link
Copy Markdown
ContributorAuthor

R: @damccorm

@damccormdamccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@damccorm
damccorm merged commit 25ca4f0 into apache:masterJun 28, 2022
@Abacn
Abacn deleted the shardfollowup branch June 28, 2022 19:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Abacn@asf-ci@benEng@fernando-wizeline@damccorm