Skip to content

Minor: Add helpful names for parameterized tests in dataframe.schemas_test - #22630

Merged
TheNeuralBit merged 1 commit into
apache:masterfrom
TheNeuralBit:schemas-parameterized-name
Aug 10, 2022
Merged

Minor: Add helpful names for parameterized tests in dataframe.schemas_test#22630
TheNeuralBit merged 1 commit into
apache:masterfrom
TheNeuralBit:schemas-parameterized-name

Conversation

@TheNeuralBit

Copy link
Copy Markdown
Member

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov

codecovBot commented Aug 9, 2022

Copy link
Copy Markdown

Codecov Report

Merging #22630 (105b00e) into master (cc0b446) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #22630 +/- ##
==========================================
- Coverage 74.20% 74.19% -0.02% 
==========================================
Files 708 708 Lines 93462 93462 ==========================================
- Hits 69354 69342 -12 - Misses 22833 22845 +12 
Partials 1275 1275 
FlagCoverage Δ
python83.59% <ø> (-0.02%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
.../python/apache_beam/testing/test_stream_service.py88.09% <0.00%> (-4.77%)⬇️
.../apache_beam/runners/interactive/dataproc/types.py93.10% <0.00%> (-3.45%)⬇️
...python/apache_beam/runners/worker/worker_status.py78.26% <0.00%> (-1.45%)⬇️
sdks/python/apache_beam/io/source_test_utils.py88.01% <0.00%> (-1.39%)⬇️
...che_beam/runners/interactive/interactive_runner.py90.06% <0.00%> (-1.33%)⬇️
...eam/runners/portability/fn_api_runner/execution.py92.44% <0.00%> (-0.65%)⬇️
...hon/apache_beam/runners/worker/bundle_processor.py93.67% <0.00%> (ø)
...eam/runners/interactive/interactive_environment.py92.02% <0.00%> (+0.30%)⬆️
sdks/python/apache_beam/utils/interactive_utils.py97.56% <0.00%> (+2.43%)⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @y1chi for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@TheNeuralBit

Copy link
Copy Markdown
MemberAuthor

@y1chi do you have time to review this? It's pretty small :)

@y1chiy1chi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheNeuralBit
TheNeuralBit merged commit 8fb4945 into apache:masterAug 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TheNeuralBit@y1chi