Uh oh!
There was an error while loading. Please reload this page.
[Go SDK]: Implement standalone single-precision float encoder - #22664
Merged
Conversation
Codecov Report
@@ Coverage Diff @@## master #22664 +/- ##
=======================================
Coverage 74.19% 74.19% =======================================
Files 708 709 +1 Lines 93465 93489 +24 =======================================
+ Hits 69347 69365 +18 - Misses 22843 22847 +4 - Partials 1275 1277 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jrmccluskey
commented
Aug 10, 2022
ContributorAuthor
Contributor
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
lostluck
approved these changes
Aug 11, 2022
lostluck
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I recommend also adding a mention of this to Changes.md, in particular in the breaking changes section, as most coder changes are "breaking", and that this is user observable behavior in the coding.
MarcoRob pushed a commit
to MarcoRob/beam
that referenced
this pull request
Sep 5, 2022
…#22664) * Implement standalone single-precision float encoder * Add fuzz test * Fix buffer size * Fix docstring * Add CHANGES.md entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a specific single-precision float coder to match Java and Python coder implementations, replacing old routing that treated
float32values asfloat64for encoding/decoding purposes.Fixes#22629
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.