Skip to content

Add shunts for Beam typehints to apache_beam.dataframe.schemas - #22680

Merged
TheNeuralBit merged 1 commit into
apache:masterfrom
TheNeuralBit:beam-typehint-shunt
Aug 11, 2022
Merged

Add shunts for Beam typehints to apache_beam.dataframe.schemas#22680
TheNeuralBit merged 1 commit into
apache:masterfrom
TheNeuralBit:beam-typehint-shunt

Conversation

@TheNeuralBit

Copy link
Copy Markdown
Member

Currently we only support mapping typing.Optional, we should also support beam.typehints.Optional.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@TheNeuralBit

Copy link
Copy Markdown
MemberAuthor

Extracted from #22575

@codecov

codecovBot commented Aug 11, 2022

Copy link
Copy Markdown

Codecov Report

Merging #22680 (e1ad20e) into master (c9c57a7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #22680 +/- ##
==========================================
- Coverage 74.19% 74.18% -0.01% 
==========================================
Files 708 708 Lines 93465 93467 +2 ==========================================
- Hits 69347 69343 -4 - Misses 22843 22849 +6 
Partials 1275 1275 
FlagCoverage Δ
python83.59% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
sdks/python/apache_beam/dataframe/schemas.py97.67% <100.00%> (+0.03%)⬆️
.../python/apache_beam/testing/test_stream_service.py88.09% <0.00%> (-4.77%)⬇️
sdks/python/apache_beam/utils/interactive_utils.py95.12% <0.00%> (-2.44%)⬇️
.../python/apache_beam/transforms/periodicsequence.py98.38% <0.00%> (-1.62%)⬇️
...che_beam/runners/interactive/interactive_runner.py90.06% <0.00%> (-1.33%)⬇️
sdks/python/apache_beam/transforms/combiners.py93.05% <0.00%> (-0.39%)⬇️
...eam/runners/interactive/interactive_environment.py91.71% <0.00%> (-0.31%)⬇️
...hon/apache_beam/runners/worker/bundle_processor.py93.30% <0.00%> (-0.25%)⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py89.09% <0.00%> (+0.15%)⬆️
sdks/python/apache_beam/io/gcp/bigquery.py74.24% <0.00%> (+0.20%)⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @yeandy for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@yeandyyeandy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheNeuralBit
TheNeuralBit merged commit 0fbb806 into apache:masterAug 11, 2022
MarcoRob pushed a commit to MarcoRob/beam that referenced this pull request Sep 5, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TheNeuralBit@yeandy