Skip to content

Go SDK Katas: Update beam module dependency - #22753

Merged
lostluck merged 3 commits into
apache:masterfrom
damondouglas:22751-go-katas-update-beam-module-dependency
Aug 24, 2022
Merged

Go SDK Katas: Update beam module dependency#22753
lostluck merged 3 commits into
apache:masterfrom
damondouglas:22751-go-katas-update-beam-module-dependency

Conversation

@damondouglas

@damondouglasdamondouglas commented Aug 17, 2022

Copy link
Copy Markdown
Contributor

This PR fixes#22751 by updating the Beam SDK learning katas module dependency.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@damondouglasdamondouglas changed the title Update beam module dependencyGo SDK Katas: Update beam module dependencyAug 17, 2022
@damondouglas

Copy link
Copy Markdown
ContributorAuthor

R: @lostluck

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Comment threadbuild.gradle.kts

// Katas files
"learning/katas/**/course-info.yaml",
"learning/katas/**/task-info.yaml",

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IntelliJ edu course creation tool updates these files and removes the license. Whenever one updates anything in the course files, they would have to manually update the license information. These files only store metadata about the course.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Lets not fight IntelliJ here, it's not a good use of anyone's time.

damccorm added a commit that referenced this pull request Aug 17, 2022
damccorm added a commit that referenced this pull request Aug 18, 2022
@lostluck
lostluck self-requested a review August 24, 2022 21:24

@lostlucklostluck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for the update! Fixing the imports to reflect the production usage is most excellent.

The SDK has triggers now, and in 2.42.0 it looks like we'll have State, if not timers, so the course can expand! But we most certainly want to wait for a slightly easier to use, portable Go runner before having a stand alone kata course demo those features.

@lostluck
lostluck merged commit ddfb690 into apache:masterAug 24, 2022
@damondouglas

Copy link
Copy Markdown
ContributorAuthor

@lostluck Thank you so much for reviewing this! We are in the process of building Tour of Beam. So perhaps we can add course content there.

MarcoRob pushed a commit to MarcoRob/beam that referenced this pull request Sep 5, 2022
@damondouglas
damondouglas deleted the 22751-go-katas-update-beam-module-dependency branch September 26, 2022 20:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Update Go SDK Code Katas Beam module dependency

2 participants

@damondouglas@lostluck