Skip to content

Fix yaml duplicated mapping key - #22952

Merged
damccorm merged 2 commits into
apache:masterfrom
Abacn:fixyaml
Aug 30, 2022
Merged

Fix yaml duplicated mapping key#22952
damccorm merged 2 commits into
apache:masterfrom
Abacn:fixyaml

Conversation

@Abacn

Copy link
Copy Markdown
Contributor
  • Fix TypeScript tests broken

Please add a meaningful description for your change here

Introduced in #22561


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

* Fix TypeScript tests broken
@Abacn

Copy link
Copy Markdown
ContributorAuthor

TypeScript tests fixed.

R: @damccorm
CC: R: @TheNeuralBit

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov

codecovBot commented Aug 30, 2022

Copy link
Copy Markdown

Codecov Report

Merging #22952 (a7569eb) into master (a60105a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #22952 +/- ##
=======================================
Coverage 73.68% 73.68% =======================================
Files 713 713 Lines 94988 94988 =======================================
+ Hits 69992 69996 +4 + Misses 23695 23691 -4 
Partials 1301 1301 
FlagCoverage Δ
python83.51% <ø> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
.../python/apache_beam/transforms/periodicsequence.py98.38% <0.00%> (-1.62%)⬇️
sdks/python/apache_beam/runners/direct/executor.py96.46% <0.00%> (-0.55%)⬇️
...hon/apache_beam/runners/worker/bundle_processor.py93.67% <0.00%> (+0.24%)⬆️
sdks/python/apache_beam/transforms/combiners.py93.43% <0.00%> (+0.38%)⬆️
sdks/python/apache_beam/io/source_test_utils.py89.40% <0.00%> (+1.38%)⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm

Copy link
Copy Markdown
Contributor

Run Typescript PreCommit

@damccorm

Copy link
Copy Markdown
Contributor

Run Go PreCommit

@Abacn

Copy link
Copy Markdown
ContributorAuthor

Thanks @damccorm for taking look at this. Tests now passed.

@damccormdamccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damccorm
damccorm merged commit 32964e1 into apache:masterAug 30, 2022
@Abacn
Abacn deleted the fixyaml branch August 30, 2022 16:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Abacn@damccorm