Skip to content

Fix nested optional row inference. - #22994

Closed
robertwb wants to merge 1 commit into
apache:masterfrom
robertwb:nested-row
Closed

Fix nested optional row inference.#22994
robertwb wants to merge 1 commit into
apache:masterfrom
robertwb:nested-row

Conversation

@robertwb

Copy link
Copy Markdown
Contributor

This was broken in 2.40 and exposed by cross-langauge work.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

This was broken in 2.40 and exposed by cross-langauge work.
@robertwb

Copy link
Copy Markdown
ContributorAuthor

R: @TheNeuralBit

@TheNeuralBit

Copy link
Copy Markdown
Member

Note a user reported #22854 which was addressed in #22899. I'm not sure we need this patch, isn't it appropriate to create an Optional[RowTypeConstraint] for a nullable nested struct?

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@robertwb

Copy link
Copy Markdown
ContributorAuthor

That is probably a better fix--didn't realize making it callable was all that was needed to make Optional[RowType] work.

@TheNeuralBit

Copy link
Copy Markdown
Member

That is probably a better fix--didn't realize making it callable was all that was needed to make Optional[RowType] work.

Yeah for now it looks like CPython considers anything callable to be a type. In 3.11 it may become even more permissive: #22899 (comment)

@robertwbrobertwb closed this Sep 6, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@robertwb@TheNeuralBit