Skip to content

Update cibuildwheel - #23024

Merged
tvalentyn merged 4 commits into
apache:masterfrom
AnandInguva:update-cibuildwheel
Sep 14, 2022
Merged

Update cibuildwheel#23024
tvalentyn merged 4 commits into
apache:masterfrom
AnandInguva:update-cibuildwheel

Conversation

@AnandInguva

@AnandInguvaAnandInguva commented Sep 3, 2022

Copy link
Copy Markdown
Contributor

Update cibuildwheel to a latest version and exclude building the muslinuxwheels


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov

codecovBot commented Sep 3, 2022

Copy link
Copy Markdown

Codecov Report

Merging #23024 (221e3fb) into master (31561e2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 221e3fb differs from pull request most recent head 6275c35. Consider uploading reports for the commit 6275c35 to get more accurate results

@@ Coverage Diff @@## master #23024 +/- ##
==========================================
- Coverage 73.71% 73.69% -0.02% 
==========================================
Files 714 714 Lines 95240 95240 ==========================================
- Hits 70203 70190 -13 - Misses 23740 23753 +13 
Partials 1297 1297 
FlagCoverage Δ
python83.51% <100.00%> (-0.02%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
sdks/python/apache_beam/ml/inference/base.py95.58% <100.00%> (ø)
.../python/apache_beam/testing/test_stream_service.py88.09% <0.00%> (-4.77%)⬇️
sdks/python/apache_beam/utils/interactive_utils.py95.12% <0.00%> (-2.44%)⬇️
...ks/python/apache_beam/runners/worker/data_plane.py87.57% <0.00%> (-1.70%)⬇️
...che_beam/runners/interactive/interactive_runner.py90.06% <0.00%> (-1.33%)⬇️
sdks/python/apache_beam/runners/direct/executor.py96.46% <0.00%> (-0.55%)⬇️
...eam/runners/interactive/interactive_environment.py91.71% <0.00%> (-0.31%)⬇️
...hon/apache_beam/runners/worker/bundle_processor.py93.54% <0.00%> (-0.13%)⬇️
sdks/python/apache_beam/runners/common.py88.59% <0.00%> (-0.13%)⬇️
sdks/python/apache_beam/io/source_test_utils.py89.40% <0.00%> (+1.38%)⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AnandInguvaAnandInguva changed the title [WIP]Update cibuildwheelUpdate cibuildwheelSep 3, 2022
@AnandInguva
AnandInguva marked this pull request as ready for review September 3, 2022 19:21
@AnandInguva

Copy link
Copy Markdown
ContributorAuthor

R @tvalentyn

from the inference."""
PredictionResult.example.__doc__ = """The input example."""
PredictionResult.inference.__doc__ = """Results for the inference on the model
PredictionResult.inference.__doc__ = """Results fo r the inference on the model

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove this once this PR gets LGTM

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @TheNeuralBit for label python.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@AnandInguva

Copy link
Copy Markdown
ContributorAuthor

stop reviewer notifications

@tvalentyntvalentyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file an issue to add support for new wheel architecture (and add a TODO), or increase the timeout. Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: requested by reviewer

@AnandInguva

Copy link
Copy Markdown
ContributorAuthor

@tvalentyn added a TODO with issue link. PTAL

@tvalentyn
tvalentyn merged commit 60c4fae into apache:masterSep 14, 2022
@AnandInguvaAnandInguva mentioned this pull request Nov 11, 2022
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AnandInguva@tvalentyn