Skip to content

GA migration and sharding Python Postcommit ML - #23312

Closed
benEng wants to merge 11 commits into
apache:masterfrom
benEng:ga-postcommit-ml
Closed

GA migration and sharding Python Postcommit ML#23312
benEng wants to merge 11 commits into
apache:masterfrom
benEng:ga-postcommit-ml

Conversation

@benEng

Copy link
Copy Markdown
Contributor

As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:

The migrated workflow was added to CI.md

DO NOT MERGE until the effort to use self-hosted runners is completed #22703


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@benEng

Copy link
Copy Markdown
ContributorAuthor

Successful execution on self-hosted runners:

https://github.com/benWize/beam/actions/runs/3084368879

@codecov

codecovBot commented Sep 20, 2022

Copy link
Copy Markdown

Codecov Report

Merging #23312 (6169840) into master (4c3750d) will increase coverage by 0.55%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #23312 +/- ##
==========================================
+ Coverage 73.36% 73.91% +0.55% 
==========================================
Files 719 737 +18 Lines 97137 104305 +7168 ==========================================
+ Hits 71260 77098 +5838 - Misses 24530 25896 +1366 + Partials 1347 1311 -36 
FlagCoverage Δ
python82.75% <ø> (-0.24%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
sdks/go/pkg/beam/core/metrics/dumper.go0.00% <0.00%> (-53.97%)⬇️
sdks/go/pkg/beam/core/metrics/store.go10.63% <0.00%> (-25.54%)⬇️
sdks/go/pkg/beam/runners/direct/gbk.go72.35% <0.00%> (-11.24%)⬇️
sdks/go/pkg/beam/core/metrics/metrics.go49.36% <0.00%> (-10.93%)⬇️
sdks/python/apache_beam/utils/python_callable.py90.32% <0.00%> (-7.72%)⬇️
sdks/go/pkg/beam/core/typex/fulltype.go41.50% <0.00%> (-7.33%)⬇️
sdks/go/pkg/beam/register/emitter.go47.69% <0.00%> (-6.37%)⬇️
sdks/go/pkg/beam/core/runtime/exec/window.go49.01% <0.00%> (-5.99%)⬇️
sdks/go/pkg/beam/options/jobopts/options.go87.27% <0.00%> (-5.91%)⬇️
sdks/go/pkg/beam/register/iter.go67.21% <0.00%> (-5.76%)⬇️
... and 124 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fernando-wizeline

Copy link
Copy Markdown
Contributor

LGTM!

@benEng
benEng marked this pull request as ready for review September 23, 2022 16:54
@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @pabloem for label python.
R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@pabloem

Copy link
Copy Markdown
Member

is this ready for review? who should review this?

@benEng

Copy link
Copy Markdown
ContributorAuthor

is this ready for review? who should review this?

Hi @pabloem, it is ready for review but the merge should wait until the self-hosted runners are ready. @damccorm could be the reviewer, he has more context on this effort!

Comment threadCI.md Outdated
- name: Run :sdks:python:test-suites:dataflow:py${{env.PYTHON_VERSION}}:postCommitITByTestDirectory
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: :sdks:python:test-suites:dataflow:py${{env.PYTHON_VERSION}}:postCommitITByTestDirectory

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pytorch tests in apache_beam/ml/inference will get skipped because the dependencies won't be installed[1] on the runner with this workflow.

def requirementsFile ="${rootDir}/sdks/python/apache_beam/ml/inference/torch_tests_requirements.txt"

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an extra step to run the Gradle task torchInferenceTest

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnandInguva is that enough to make this work? Do we need to do the same thing for other frameworks (e.g. sklearn?)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be sufficient to run the current ML tests

benEngand others added 3 commits October 5, 2022 19:44
Co-authored-by: Anand Inguva <34158215+AnandInguva@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @pabloem@damccorm

Comment thread.github/workflows/job-postcommit-python-ml.yml Outdated
@AnandInguva

Copy link
Copy Markdown
Contributor

Left one more comment. apart from that, LGTM

@github-actions

Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @pabloem@damccorm

@github-actions

Copy link
Copy Markdown
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@damccorm

Copy link
Copy Markdown
Contributor

stop reviewer notifications

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: requested by reviewer

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@benEng@fernando-wizeline@pabloem@AnandInguva@damccorm