Uh oh!
There was an error while loading. Please reload this page.
Add flink-conf-dir to flink on portable runner, fix some flink test suites - #24254
Add flink-conf-dir to flink on portable runner, fix some flink test suites#24254damccorm wants to merge 20 commits into
Conversation
Codecov Report
@@ Coverage Diff @@## master #24254 +/- ##
==========================================
- Coverage 73.46% 73.37% -0.09%
==========================================
Files 714 717 +3 Lines 96497 96855 +358 ==========================================
+ Hits 70889 71066 +177 - Misses 24286 24467 +181
Partials 1322 1322
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
damccorm
commented
Nov 23, 2022
Run Go Flink ValidatesRunner |
damccorm
commented
Nov 23, 2022
Run Python Examples_Flink |
damccorm
commented
Nov 23, 2022
Run Python Examples_Flink |
damccorm
commented
Nov 23, 2022
Run Python Examples_Flink |
damccorm
commented
Nov 23, 2022
Run Python Examples_Flink |
damccorm
commented
Nov 23, 2022
This change fixes the |
More Examples_Python_Flink tests failing with |
damccorm
commented
Nov 28, 2022
I think that would probably work, I won't have bandwidth to take it forward though. In the meantime, I added #24342 to at least sickbay some test and get us green |
In #24228 we applied a general fix for some classes of flink failures - this cleans up some previous attempts to work around the issues and fixes them. It also allows users to pass in a flink-conf-dir arg to the portable runner.
Fixes#21094
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.