Skip to content

[release-2.44.0] Cherry-pick: Revert 23969 sqlttypes - #24492

Merged
kennknowles merged 2 commits into
apache:release-2.44.0from
Abacn:revert-23969-sqlttypes
Dec 8, 2022
Merged

[release-2.44.0] Cherry-pick: Revert 23969 sqlttypes#24492
kennknowles merged 2 commits into
apache:release-2.44.0from
Abacn:revert-23969-sqlttypes

Conversation

@Abacn

@AbacnAbacn commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

Fixes#24415

Please add a meaningful description for your change here

Cherry pick #24489 into release-2.44.0 branch.

Justification: #23969 introduced a regression in 2.44.0. It introduces SqlType.TIMESTAMP (micros_instant) logical type when converting from avro logical type TimestampMicros, but this Beam portable logical type is not yet supported in Beam SQL. Similar regression may occur other than Beam SQL where micros_instant is not supported.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@Abacn

Abacn commented Dec 2, 2022

Copy link
Copy Markdown
ContributorAuthor

R: @kennknowles

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@AbacnAbacn changed the title [release-2.43.0] Cherry-pick: Revert 23969 sqlttypes[release-2.44.0] Cherry-pick: Revert 23969 sqlttypesDec 2, 2022
@kennknowles

Copy link
Copy Markdown
Member

LGTM and I will merge once it is green.

@Abacn

Abacn commented Dec 2, 2022

Copy link
Copy Markdown
ContributorAuthor

Run Java PreCommit

@Abacn

Abacn commented Dec 2, 2022

Copy link
Copy Markdown
ContributorAuthor

changes on sdk.core often makes the first run of precommit timeout as gradle cache is not used and it tries to re-compile all codes.

@Abacn

Abacn commented Dec 2, 2022

Copy link
Copy Markdown
ContributorAuthor

Tests actually ended. Java Precommit fail org.apache.beam.sdk.io.pulsar.PulsarIOTest.testReadFromSimpleTopic known flake, the other two are succeeded.

@Abacn

Abacn commented Dec 5, 2022

Copy link
Copy Markdown
ContributorAuthor

Just a reminder (don't want this PR to block the release) @kennknowles

@kennknowles

Copy link
Copy Markdown
Member

run java precommit

@kennknowles

Copy link
Copy Markdown
Member

it was a pulsar flake, but I have time to kick it again to get green

@Abacn

Abacn commented Dec 6, 2022

Copy link
Copy Markdown
ContributorAuthor

org.apache.beam.sdk.io.pulsar.PulsarIOTest.testReadFromSimpleTopic failed again

@Abacn

Abacn commented Dec 6, 2022

Copy link
Copy Markdown
ContributorAuthor

Run Java PreCommit

@Abacn

Abacn commented Dec 7, 2022

Copy link
Copy Markdown
ContributorAuthor

This time is org.apache.beam.runners.samza.runtime.AsyncDoFnRunnerTest.testPipelineWithState (related to #23745, another sazma runner test)

@kennknowles

Copy link
Copy Markdown
Member

OK I am going to merge anyhow. That test is disabled on master now.

@kennknowles
kennknowles merged commit fd882cd into apache:release-2.44.0Dec 8, 2022
@Abacn
Abacn deleted the revert-23969-sqlttypes branch December 8, 2022 17:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Abacn@kennknowles