Skip to content

Import blacklist#245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asfgit merged 2 commits into from
Apr 26, 2016
+7 −3
Merged

Import blacklist #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d6d59e
checkstyle.xml: blacklist repackaged code from Google API Client
dhalperi Apr 26, 2016
2b3b140
PubsubClient: fix use of blacklisted Preconditions
dhalperi Apr 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdks/java/checkstyle.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -122,6 +122,10 @@ page at http://checkstyle.sourceforge.net/config.html -->
<property name="severity" value="error"/>
</module>

<module name="IllegalImport">
<property name="illegalPkgs" value="com.google.api.client.repackaged"/>
</module>

<module name="UnusedImports">
<property name="severity" value="error"/>
<property name="processJavadoc" value="true"/>
Expand Down
6 changes: 3 additions & 3 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/io/PubsubClient.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@

package org.apache.beam.sdk.io;

import com.google.api.client.repackaged.com.google.common.base.Preconditions;
import static com.google.common.base.Preconditions.checkState;

import java.io.IOException;
import java.io.Serializable;
Expand DownExpand Up@@ -88,7 +88,7 @@ public String getPath() {

public String getV1Beta1Path() {
String[] splits = path.split("/");
Preconditions.checkState(splits.length == 4);
checkState(splits.length == 4);
return String.format("/subscriptions/%s/%s", splits[1], splits[3]);
}

Expand DownExpand Up@@ -136,7 +136,7 @@ public String getPath() {

public String getV1Beta1Path() {
String[] splits = path.split("/");
Preconditions.checkState(splits.length == 4);
checkState(splits.length == 4);
return String.format("/topics/%s/%s", splits[1], splits[3]);
}

Expand Down