Uh oh!
There was an error while loading. Please reload this page.
BEAM-13261 added max connections setting - #24851
Merged
aromanenko-dev merged 2 commits intoJan 17, 2023
Merged
Conversation
pas725
commented
Jan 1, 2023
ContributorAuthor
R: @jbonofre |
Contributor
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
aromanenko-dev
self-requested a review
January 16, 2023 14:25
aromanenko-dev
approved these changes
Jan 16, 2023
aromanenko-dev
left a comment
Contributor
There was a problem hiding this comment.
Thanks! LGTM
Just a small note, ptal
Uh oh!
There was an error while loading. Please reload this page.
Abacn
commented
Jan 18, 2023
Contributor
This PR broke Python postcommi's jdbc xlang test: https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_Python38/3630/ |
Abacn
reviewed
Jan 18, 2023
| dataSourceConfiguration = dataSourceConfiguration.withConnectionInitSqls(initSqls); | ||
| } | ||
| @Nullable Integer maxConnections = config.getInt32("maxConnections"); |
Contributor
There was a problem hiding this comment.
we should tolerate the incoming schema not containing this field for backward compatibility
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds max pool connections as a configurable parameter while creating Datasource.
Task: #21200
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.