Skip to content

BEAM-13261 added max connections setting - #24851

Merged
aromanenko-dev merged 2 commits into
apache:masterfrom
pas725:beam-13261-expose-max-connections-setting
Jan 17, 2023
Merged

BEAM-13261 added max connections setting#24851
aromanenko-dev merged 2 commits into
apache:masterfrom
pas725:beam-13261-expose-max-connections-setting

Conversation

@pas725

@pas725pas725 commented Jan 1, 2023

Copy link
Copy Markdown
Contributor

Adds max pool connections as a configurable parameter while creating Datasource.

Task: #21200


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@pas725

Copy link
Copy Markdown
ContributorAuthor

R: @jbonofre
R: @timrobertson100

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@aromanenko-devaromanenko-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM
Just a small note, ptal

Comment threadsdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java Outdated
@aromanenko-dev
aromanenko-dev merged commit 869150c into apache:masterJan 17, 2023
@Abacn

Copy link
Copy Markdown
Contributor

This PR broke Python postcommi's jdbc xlang test: https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_Python38/3630/

 with ExternalTransform.service(self._expansion_service) as service:
response = service.Expand(request)
if response.error:
> raise RuntimeError(response.error)
E RuntimeError: java.lang.IllegalArgumentException: Cannot find field maxConnections in schema Fields:

dataSourceConfiguration = dataSourceConfiguration.withConnectionInitSqls(initSqls);
}

@Nullable Integer maxConnections = config.getInt32("maxConnections");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should tolerate the incoming schema not containing this field for backward compatibility

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pas725@Abacn@aromanenko-dev