Skip to content

Support SqlTypes Date in AvroUtils (sync) - #24854

Merged
aromanenko-dev merged 1 commit into
apache:masterfrom
aromanenko-dev:ext_avro_24756
Jan 2, 2023
Merged

Support SqlTypes Date in AvroUtils (sync)#24854
aromanenko-dev merged 1 commit into
apache:masterfrom
aromanenko-dev:ext_avro_24756

Conversation

@aromanenko-dev

Copy link
Copy Markdown
Contributor

Sync changes from #24756 to extensions/avro

#23299


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@aromanenko-dev

Copy link
Copy Markdown
ContributorAuthor

R: @Abacn
CC: @mosche

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@AbacnAbacn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

nit: this line missed:

* <------ LogicalType(urn="beam:logical_type:date:v1")

@aromanenko-dev

Copy link
Copy Markdown
ContributorAuthor

@Abacn Ops, thanks! Fixed

@aromanenko-dev
aromanenko-dev merged commit 37358ff into apache:masterJan 2, 2023
@aromanenko-dev
aromanenko-dev deleted the ext_avro_24756 branch January 2, 2023 16:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@aromanenko-dev@Abacn