Skip to content

[ToB][Frontend] Gradle tasks for ToB frontend - #24919

Merged
damccorm merged 6 commits into
apache:masterfrom
akvelon:issue24563_tobf_gradle
Jan 25, 2023
Merged

[ToB][Frontend] Gradle tasks for ToB frontend#24919
damccorm merged 6 commits into
apache:masterfrom
akvelon:issue24563_tobf_gradle

Conversation

@nausharipov

@nausharipovnausharipov commented Jan 6, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves#24563

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@nausharipov

nausharipov commented Jan 6, 2023

Copy link
Copy Markdown
ContributorAuthor

R: @alexeyinkin

@github-actions

github-actionsBot commented Jan 6, 2023

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

alexeyinkin
alexeyinkin suggested changes Jan 6, 2023
View reviewed changes
Comment threadlearning/tour-of-beam/frontend/build.gradle.kts Outdated

doLast {
exec {
// Exact paths instead of '.' so it does not go into playground_components

@alexeyinkinalexeyinkinJan 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete such comments here and in Playground so we can copy tasks between them.

Comment threadlearning/tour-of-beam/frontend/build.gradle.kts Outdated

tasks.register("pubGet") {
group = "build"
description = "Get packages for the playground frontend project"

@alexeyinkinalexeyinkinJan 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strip project names from descriptions so the same ones can be used for both Playground and ToB.

@codecov

codecovBot commented Jan 6, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #24919 (bb0b08e) into master (95e5391) will increase coverage by 0.08%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #24919 +/- ##
==========================================
+ Coverage 73.07% 73.16% +0.08% 
==========================================
Files 735 734 -1 Lines 98133 98358 +225 ==========================================
+ Hits 71713 71960 +247 + Misses 25061 25038 -23 - Partials 1359 1360 +1
FlagCoverage Δ
python82.76% <ø> (+0.06%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
sdks/go/pkg/beam/core/metrics/dumper.go49.20% <0.00%> (-4.77%)⬇️
sdks/go/pkg/beam/core/metrics/metrics.go60.29% <0.00%> (-0.25%)⬇️
sdks/python/apache_beam/runners/common.py88.59% <0.00%> (-0.13%)⬇️
sdks/go/pkg/beam/transforms/sql/sql.go
...ks/python/apache_beam/runners/worker/sdk_worker.py89.40% <0.00%> (+0.16%)⬆️
sdks/python/apache_beam/typehints/typehints.py93.43% <0.00%> (+0.38%)⬆️
...dks/python/apache_beam/options/pipeline_options.py96.13% <0.00%> (+2.18%)⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

alexeyinkin
alexeyinkin approved these changes Jan 6, 2023
View reviewed changes

@alexeyinkinalexeyinkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (internal review).

@nausharipov
nausharipov marked this pull request as ready for review January 6, 2023 12:21
@nausharipov

nausharipov commented Jan 6, 2023

Copy link
Copy Markdown
ContributorAuthor

R: @damondouglas

@alexeyinkinalexeyinkin mentioned this pull request Jan 12, 2023
Merged
4 tasks
@nausharipov

nausharipov commented Jan 19, 2023

Copy link
Copy Markdown
ContributorAuthor

The README will be updated in a separate task: #25076

damondouglas
damondouglas approved these changes Jan 25, 2023
View reviewed changes

@damondouglasdamondouglas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damccorm LGTM

@damccorm
damccorm merged commit 72d2776 into apache:masterJan 25, 2023
@nausharipov
nausharipov deleted the issue24563_tobf_gradle branch January 25, 2023 15:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damondouglasdamondouglasdamondouglas approved these changes
@damccormdamccormdamccorm approved these changes
+1 more reviewer
@alexeyinkinalexeyinkinalexeyinkin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildlearning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Task]: Gradle tasks for ToB frontend

4 participants

@nausharipov@damondouglas@damccorm@alexeyinkin