Uh oh!
There was an error while loading. Please reload this page.
Allow to set timeout for finishing a remote bundle in Samza portable runner - #25031
Conversation
alnzng
commented
Jan 17, 2023
@xinyuiscool please help take a look, thanks. |
mynameborat
left a comment
There was a problem hiding this comment.
Can we add unit tests?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
alnzng
commented
Jan 17, 2023
I didn't do that because there is no test cases created for this |
alnzng
commented
Jan 17, 2023
@mynameborat Thanks for helping review. I addressed your comments, let me know if you have other questions. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
7023b18 to
d59a775CompareUh oh!
There was an error while loading. Please reload this page.
d59a775 to
b058574Compareb058574 to
a677df5Comparea677df5 to
db7073dCompare
addresses #25030
We have observed that some UDFs(with bugs or imported some bad third-party libs) could hang the runner and SDK harness processes in Samza portable mode. Both runner and SDK harness processes are in a zombie state and have no data processing in this case, however, the processes are not able to be shut down although Samza runner provides some built-in timeout functionality.
This change will allow the users to set a timeout for closing a remote bundle in Samza portable runner. Once the timeout occurred, the runner and SDK processes will be shut down properly by Samza's built-in task timeout functionality if enabled.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.