Uh oh!
There was an error while loading. Please reload this page.
Added MetadataSpannerConfig class for generating SpannerConfig for ac… - #25193
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @lukecwik for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Abacn
commented
Feb 8, 2023
created #25383 for tracking. this PR would close it. |
Abacn
left a comment
There was a problem hiding this comment.
Sorry for the delay. Had some comments below.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…cessing change stream metadata database
Abacn
commented
Feb 10, 2023
please avoid rebase unless merge conflict. this mixes review history. tests already run on feature branch merged onto master |
Abacn
commented
Feb 10, 2023
retest this please |
Abacn
commented
Feb 10, 2023
looks like jenkins not triggering. will try again |
Abacn
commented
Feb 10, 2023
test failure Java_Examples_Dataflow_Java17 unrelated. merging for now. Thanks! |
…cessing change stream metadata database (apache#25193)
This is a follow-up change to the quick fix that was implemented in #25108. It is a more robust solution that makes the code less brittle so that a similar config issue doesn't crop up again in the future. For details of the problem and why this solution is necessary, see #25108 (comment).