Skip to content

Rename _namespace to _get_display_data_namespace - #26353

Merged
tvalentyn merged 2 commits into
apache:masterfrom
svetakvsundhar:20907
Apr 20, 2023
Merged

Rename _namespace to _get_display_data_namespace#26353
tvalentyn merged 2 commits into
apache:masterfrom
svetakvsundhar:20907

Conversation

@svetakvsundhar

Copy link
Copy Markdown
Contributor

Fixes#20907


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@svetakvsundhar
svetakvsundhar marked this pull request as draft April 19, 2023 18:34
@codecov

codecovBot commented Apr 19, 2023

Copy link
Copy Markdown

Codecov Report

Merging #26353 (2dd7f35) into master (e0e1398) will increase coverage by 0.64%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #26353 +/- ##
==========================================
+ Coverage 71.21% 71.85% +0.64% 
==========================================
Files 787 752 -35 Lines 103330 101477 -1853 ==========================================
- Hits 73588 72921 -667 + Misses 28246 27060 -1186 
Partials 1496 1496 
FlagCoverage Δ
python81.05% <100.00%> (+1.20%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
sdks/python/apache_beam/io/textio.py94.89% <ø> (ø)
sdks/python/setup.py0.00% <ø> (ø)
sdks/python/apache_beam/transforms/display.py94.03% <100.00%> (ø)

... and 47 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@svetakvsundhar

Copy link
Copy Markdown
ContributorAuthor

Run PythonLint PreCommit

@svetakvsundhar
svetakvsundhar marked this pull request as ready for review April 19, 2023 21:26
@svetakvsundhar

Copy link
Copy Markdown
ContributorAuthor

R: @tvalentyn

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn
tvalentyn merged commit 080eef0 into apache:masterApr 20, 2023
svetakvsundhar added a commit to svetakvsundhar/beam that referenced this pull request Apr 26, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document: _namespace is a reserved field for DoFns (used for display data)

2 participants

@svetakvsundhar@tvalentyn