Uh oh!
There was an error while loading. Please reload this page.
[BEAM-154] Use dependencyManagement and pluginManagement to keep all … - #267
[BEAM-154] Use dependencyManagement and pluginManagement to keep all …#267jbonofre wants to merge 1 commit into
Conversation
| <executions> | ||
| <execution> | ||
| <id>attach-sources</id> | ||
| <phase>compile</phase> |
There was a problem hiding this comment.
Can we attach this to a later phase, such as package, to speed up compile?
kennknowles
commented
Apr 29, 2016
One little thought: if we are moving to one common |
jbonofre
commented
Apr 29, 2016
It's what I'm planning once the checkstyle errors will be fixed (I'm working on it). Actually, I plan to define some plugin by default, and a BOM for the dependencies. This is the first step. |
kennknowles
commented
Apr 29, 2016
LGTM to get the big picture setup and forward-fix any little things, but I think Davor will probably want to take a close look. R: @davorbonaci |
jbonofre
commented
Apr 29, 2016
Yup, thanks for the review @kennknowles ! Much appreciated ! |
| <dependencyManagement> | ||
| <dependencies> | ||
| <!-- Beam SDK --> |
There was a problem hiding this comment.
I'd probably remove these comments, because we aren't consistent (some artifacts have it and others don't), and they aren't particularly informative.
I'd leave comment at the beginning of the testing scope section, and those that describe the exclusions.
There was a problem hiding this comment.
It makes sense, let me do it.
davorbonaci
commented
May 1, 2016
This is a great improvement! Separately, I think we should think about build speed and potentially adjust plugins to make sure things are optimized for the development workflow, while the CI tools execute everything. We can defer this to a later point. |
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-source-plugin</artifactId> | ||
| </plugin> |
There was a problem hiding this comment.
I think it's enough to include this in the root Flink Runner pom.
There was a problem hiding this comment.
Good idea, let me update this way.
jbonofre
commented
May 2, 2016
Rebased and updated according to the comments. |
davorbonaci
commented
May 2, 2016
LGTM, modulo resolution of the comment regarding google-http-client-jackson's exclusion of transitive dependencies. |
mxm
commented
May 3, 2016
+1 from me as well. Perhaps we could add the minimum version check to the project pom but it is not super pressing. |
jbonofre
commented
May 3, 2016
Agree: I will put the enforcer on the main parent pom. |
…modules sync in term of version
jbonofre
commented
May 3, 2016
Rebased and updated according to the comments. FYI, checkstyle and enforcer will be submitted in other PRs. |
davorbonaci
commented
May 3, 2016
LGTM. Merge in progress. |
jbonofre
commented
May 3, 2016
Awesome thanks ! |
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
Use of dependencyManagement and pluginManagement to align versions between modules.
There's checkstyle errors in several modules, I will fix in new commits.