Uh oh!
There was an error while loading. Please reload this page.
[BEAM-115] Make in-process GroupByKey consistent with Beam model - #268
Merged
Conversation
kennknowlesforce-pushed
the
InProcessGroupByKey
branch
2 times, most recently
from
April 29, 2016 22:17
367ce36 to
1a54583Comparekennknowles
commented
Apr 29, 2016
MemberAuthor
Rebased onto new runner location. R: @tgroh I'll grab a committer's attention once you have considered this. |
kennknowlesforce-pushed
the
InProcessGroupByKey
branch
from
May 5, 2016 19:51
2b2da0d to
4d78efbComparedhalperi
commented
May 13, 2016
Contributor
@kennknowles@tgroh is this important? I was told that InProcess is "done" |
This introduces or clarifies the following transforms: - InProcessGroupByKey, which expands like GroupByKeyViaGroupByKeyOnly but with different intermediate PCollection types. - InProcessGroupByKeyOnly, which outputs KeyedWorkItem<K, V>. This existed already under a different name. - InProcessGroupAlsoByWindow, which is evaluated directly and accepts input elements of type KeyedWorkItem<K, V>.
kennknowlesforce-pushed
the
InProcessGroupByKey
branch
from
May 13, 2016 19:04
4d78efb to
aad284aCompareMemberAuthor
This is part of the movement towards the new Beam runner API. The runner itself is done relative to the general state of things with all the runners. This does not pertain to delivering the runner itself. |
kennknowles
commented
May 13, 2016
MemberAuthor
R: @dhalperi since you asked and the tests are now passing. Previously, tests failed and that's why this wasn't in weeks ago. But now with a rebase they are fixed. Likely it was bugs in the runner since I proposed this before it was done. |
tgroh
commented
May 19, 2016
Member
LGTM |
| private BundleFactory bundleFactory = InProcessBundleFactory.create(); | ||
| @Test | ||
| public void testInMemoryEvaluator() throws Exception { |
dhalperi
commented
May 19, 2016
Contributor
LGTM |
iemejia pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
[euphoria-core] apache#259 Hints are not runtime specific.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.