Uh oh!
There was an error while loading. Please reload this page.
Remove fastjson library - #28007
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Assigning reviewers. If you would like to opt out of this review, comment R: @bvolpato for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Abacn
commented
Aug 16, 2023
Thanks for working on this! There are merge conflicts - could you please rebase onto the current master? Also, consider add this change to CHANGES.md. |
Uh oh!
There was an error while loading. Please reload this page.
gabry-lab
commented
Aug 16, 2023
added |
Uh oh!
There was an error while loading. Please reload this page.
Abacn
commented
Aug 16, 2023
Run SQL PostCommit |
Abacn
commented
Aug 16, 2023
There are test failures: Previously a ill-formed json Similarly, it is nice to tolerant trailing comma |
gabry-lab
commented
Aug 17, 2023
I will add |
Abacn
commented
Aug 17, 2023
Thanks again for the fix. It appears fastjson parser in general is more relax than the default jackson mapper. Let me do some small experiments regarding the default behavior of two parsers, specifically, the list in https://fasterxml.github.io/jackson-core/javadoc/2.9/com/fasterxml/jackson/core/JsonParser.Feature.html |
Abacn
commented
Aug 17, 2023
Experiment result shows fastjson in general is much more relax in non-standard syntax. We may need to add other configs, see below.
|
Uh oh!
There was an error while loading. Please reload this page.
…ensions/sql/TableUtils.java more configs to default behaviour Co-authored-by: Yi Hu <huuyyi@gmail.com>
Abacn
commented
Aug 18, 2023
Run SQL PostCommit |
fix#24154,
hi @apilloud can you help to review this PR?