Skip to content

[BEAM-97] Input watermarks can never be null - #30

Closed
mshields822 wants to merge 5 commits into
apache:masterfrom
mshields822:non-null-output-watermark
Closed

[BEAM-97] Input watermarks can never be null#30
mshields822 wants to merge 5 commits into
apache:masterfrom
mshields822:non-null-output-watermark

Conversation

@mshields822

@mshields822mshields822 commented Mar 7, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@mshields822

mshields822 commented Mar 7, 2016

Copy link
Copy Markdown
ContributorAuthor

R=@kennknowles

@mshields822

mshields822 commented Mar 7, 2016

Copy link
Copy Markdown
ContributorAuthor

This also includes some additional comments and asserts related to pairing output watermark holds with their cleanup timers. They could be separated but since everything is around watermark hold robustness I think we should keep them together.

@mshields822

mshields822 commented Mar 8, 2016

Copy link
Copy Markdown
ContributorAuthor

Hold off on this one please.

@mshields822

mshields822 commented Mar 10, 2016

Copy link
Copy Markdown
ContributorAuthor

@kennknowles
To to reiterate - this one need to wait for a corresponding Google worker cl, and that needs to wait for some backward compat tests to go through.

@mshields822

mshields822 commented Mar 22, 2016

Copy link
Copy Markdown
ContributorAuthor

@kennknowles
This is now ready to go in.

kennknowles
kennknowles reviewed Mar 24, 2016
View reviewed changes
Comment threadsdk/src/main/java/com/google/cloud/dataflow/sdk/util/TriggerRunner.java Outdated
}

public void onFire(W window, Timers timers, StateAccessor<?> state) throws Exception {
// shouldFire should be false.

@kennknowleskennknowlesMar 24, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? I think rootTrigger.invokeShouldFire(context) should be true, otherwise it is forbidden to call invokeOnFire.

@mshields822mshields822Mar 25, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kennknowles

kennknowles commented Mar 24, 2016

Copy link
Copy Markdown
Member

Nice. This makes things so much cleaner.

@mshields822

mshields822 commented Mar 25, 2016

Copy link
Copy Markdown
ContributorAuthor

PTAL

@mshields822

mshields822 commented Mar 25, 2016

Copy link
Copy Markdown
ContributorAuthor

Oh, I'm too late for the rename - will need to rebase.

@mshields822

mshields822 commented Mar 25, 2016

Copy link
Copy Markdown
ContributorAuthor

All good.

davorbonaci added a commit to GoogleCloudPlatform/DataflowJavaSDK that referenced this pull request Mar 25, 2016
@davorbonaci
Merge pull request#171from dhalperi/backport-30
339eb0e
Backport apache/beam#30
echauchot added a commit to echauchot/beam that referenced this pull request May 12, 2017
@echauchot
Fix query5: Add comment on key lifting
962919d
issue apache#30
cosmoskitten pushed a commit to cosmoskitten/beam that referenced this pull request Jun 16, 2017
@echauchot
Improve query5, query10 and query11
39f51ba
query5: Add comment on key lifting (issue apache#30)
query10: Add comment for strange groupByKey (issue apache#31)
query11: Replace Count.perKey by Count.perElement (issue apache#32)
asfgit pushed a commit that referenced this pull request Aug 23, 2017
@echauchot@iemejia
Improve query5, query10 and query11
7bfc982
query5: Add comment on key lifting (issue #30)
query10: Add comment for strange groupByKey (issue #31)
query11: Replace Count.perKey by Count.perElement (issue #32)
lukecwik referenced this pull request in lukecwik/incubator-beam Mar 22, 2018
@bsidhom
Merge pull request#30from bsidhom/control-client-pool
0582f9a
Add ControlClientPool interface and fix broken JobResourceManagerTest
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Apr 30, 2020
@kgabryje@robertwb
Rewrite github_sample to 1 line (apache#30)
02232bf
* Rewrite github_sample to 1 line
* Add license to table shortcode
hengfengli referenced this pull request in hengfengli/beam Mar 21, 2022
@zoercai
refactor: QueryChangeStreamAction (#30)
73d2c3c
ajothomas referenced this pull request in ajothomas/beam Jun 27, 2022
@ajothomas
Wiring Distribution metrics as samza gauges (#30)
95616f6
sjvanrossum pushed a commit to sjvanrossum/beam that referenced this pull request May 17, 2023
@laysakura
Merge pull requestapache#30from laysakura/feat/serde-Coder
f8ad327
feat: serialize/deserialize custom coders
pl04351820 pushed a commit to pl04351820/beam that referenced this pull request Dec 20, 2023
@HemangChothani
docs: document admin client (apache#174)
f099736
Closes: apache#30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mshields822@kennknowles