Skip to content

[Test only] Introduce checkpointtimeout - #30853

Closed
Abacn wants to merge 2 commits into
apache:masterfrom
Abacn:timeoutsession
Closed

[Test only] Introduce checkpointtimeout#30853
Abacn wants to merge 2 commits into
apache:masterfrom
Abacn:timeoutsession

Conversation

@Abacn

@AbacnAbacn commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

Test only, attempt to fix#30218 (comment)

However, found that if the checkpoint can expire, the messages unacked will get redelivered, but the new checkpoint won't finalize either, causing repetitive redeliver and duplicate messages.

I now think the underlying issue is that finalizing checkpoint is not guaranteed to happen timely. This is work as expected. Expiring outstanding checkpoint won't resolve the stucked messages when throughput is low given the asynchronous ack mechanism.

Thus, another option is to expose "Auto acknowledge" client option to JmsIO to retain the previous behavior, however, data loss is possible, as in previous implementation

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Abacn marked this pull request as draft April 4, 2024 18:47
@AbacnAbacn mentioned this pull request Apr 4, 2024
3 tasks
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Abacn