Uh oh!
There was an error while loading. Please reload this page.
Revert "Revert #30533: Automatically execute unbounded pipelines in streaming mode." - #30894
Closed
damccorm wants to merge 1 commit into
Closed
Revert "Revert #30533: Automatically execute unbounded pipelines in streaming mode."#30894damccorm wants to merge 1 commit into
damccorm wants to merge 1 commit into
Conversation
…s in str…" This reverts commit e207a14.
liferoad
reviewed
Apr 8, 2024
| if any(pcoll.is_bounded == beam_runner_api_pb2.IsBounded.UNBOUNDED | ||
| for pcoll in self.proto_pipeline.components.pcollections.values()): | ||
| options.view_as(StandardOptions).streaming = True |
Contributor
There was a problem hiding this comment.
if users specify streaming, can we honor the one specified by the users? This at least can let users keep the current behavior.
damccorm
commented
Apr 12, 2024
ContributorAuthor
We're taking a different (runner driven) approach here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #30706
This change was initially correct