Uh oh!
There was an error while loading. Please reload this page.
Change caching of global window inputs to be guarded by experiment - #31013
Merged
Conversation
scwhittleforce-pushed
the
side_input_option
branch
from
April 17, 2024 12:54
8659684 to
b04f7a3Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
scwhittleforce-pushed
the
side_input_option
branch
from
April 17, 2024 17:28
b04f7a3 to
668b675Comparedisable_global_windowed_args_caching
scwhittleforce-pushed
the
side_input_option
branch
from
April 17, 2024 17:41
668b675 to
6e4592bComparescwhittle
commented
Apr 17, 2024
ContributorAuthor
R: @tvalentyn |
Contributor
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
tvalentyn
approved these changes
Apr 18, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
scwhittle added a commit
to scwhittle/beam
that referenced
this pull request
Apr 18, 2024
…pache#31013) * Change caching of global window inputs to be guarded by experiment disable_global_windowed_args_caching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As there are potential performance concerns, put the removal of caching of global window inputs added by #30991 behind an experiment.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.