Uh oh!
There was an error while loading. Please reload this page.
[BEAM-117] Validate display data registration in Dataflow Runner - #325
Conversation
swegner
commented
May 11, 2016
R: @bjchambers |
df8b28d to
9cfa061Compareswegner
commented
May 12, 2016
@bjchambers is out-of-office, @lukecwik can you take a look? |
swegner
commented
May 12, 2016
/cc @tgroh |
| @@ -497,7 +495,6 @@ public void testWritingDisplayData() { | |||
| assertThat(displayData, hasDisplayItem("tableId", "fooTable")); | |||
| // BigtableIO adds user-agent to options; assert only on key and not value. | |||
swegner
commented
May 14, 2016
I've addressed all feedback so far. Please take another look. @tgroh |
| <artifactId>java-sdk-all</artifactId> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
I'm surprised this validation required adding dependencies on avro and datastore. Is there a reason these dependencies appeared now but not before?
There was a problem hiding this comment.
Previously there was no direct dependency on Avro/Datastore in Dataflow runner. This change adds integration tests which directly reference classes in these packages.
bjchambers
commented
May 16, 2016
LGTM after we confirm the new dependencies and get the build passing. |
swegner
commented
May 16, 2016
@bjchambers Travis is green, Jenkins failure looks like a flake. |
d9ac1a6 to
6269b8fCompareswegner
commented
May 16, 2016
@bjchambers squashed. I don't know why Jenkins is still angry, but this is rebased on top of current HEAD. |
swegner
commented
May 16, 2016
Backport: GoogleCloudPlatform/DataflowJavaSDK#230 |
Implement getSplitPointsConsumed() in BigtableIO
Co-authored-by: Craig Labenz <craiglabenz@google.com>
….1 (apache#325…" (apache#38420) This reverts commit 72d46ce.
….1 (apache#325…" (apache#38420) This reverts commit 72d46ce.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
The DataflowRunner (like other runners) transforms pipelines during construction and sends only primitive transforms to its service. This PR validates that primitive transforms are correctly registering display data for IO transforms.