Skip to content

[BEAM-117] Window display data should be safe for null windowFn - #330

Closed
swegner wants to merge 1 commit into
apache:masterfrom
swegner:displaydata-windowfn
Closed

[BEAM-117] Window display data should be safe for null windowFn#330
swegner wants to merge 1 commit into
apache:masterfrom
swegner:displaydata-windowfn

Conversation

@swegner

@swegnerswegner commented May 12, 2016

Copy link
Copy Markdown
Contributor

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@swegner

Copy link
Copy Markdown
ContributorAuthor

R: @tgroh

@tgroh

Copy link
Copy Markdown
Member

LGTM

@swegner

Copy link
Copy Markdown
ContributorAuthor

Thanks @tgroh.

@dhalperi, can you give final approval and merge?

@dhalperi

Copy link
Copy Markdown
Contributor

LGTM, merged

@swegner
swegner deleted the displaydata-windowfn branch May 16, 2016 18:58
@swegner

Copy link
Copy Markdown
ContributorAuthor

dhalperi pushed a commit to dhalperi/beam that referenced this pull request Aug 23, 2016
* Check for existence of job before polling. Closesapache#330.
In case of local runners, export job does not exists, check if job
exists before polling for result. This will prevent unnecessary
exceptions, polling in local mode.
* Merge PR-331, and fixups.
* address feedback
iemejia pushed a commit to iemejia/beam that referenced this pull request Jan 12, 2018
pl04351820 pushed a commit to pl04351820/beam that referenced this pull request Dec 20, 2023
* changes without context
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
* chore: add pre-commit-config to renovate ignore paths
Disable renovate PRs on the .pre-commit-config.yaml which is templated from synthtool. https://docs.renovatebot.com/configuration-options/#ignorepaths
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Mon Mar 15 09:05:39 2021 -0600
Source-Repo: googleapis/synthtool
Source-Sha: 2c54c473779ea731128cea61a3a6c975a08a5378
Source-Link: googleapis/synthtool@2c54c47
Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@swegner@tgroh@dhalperi