Uh oh!
There was an error while loading. Please reload this page.
Update gcp bom to 26.50.0 - #33192
Conversation
damccorm
commented
Nov 22, 2024
Some failures are caused because proto fields can no longer be null (they'll at least have a default implementation). Addressing this now |
Assigning reviewers. If you would like to opt out of this review, comment R: @m-trieu for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
commented
Jan 2, 2025
cc/ @ldetmer |
Abacn
commented
Jan 7, 2025
damccorm
commented
Jan 7, 2025
Thanks - #33525 should fix the first issue, working on a fix for the second |
Abacn
commented
Jan 7, 2025
Thanks, persumably debezium test is the same cause? (which could be trickier as we have conflict protobuf version for DebeziumIO then) |
damccorm
commented
Jan 7, 2025
Yeah, I'm seeing if I can upgrade our debezium dependency version. That does seem like a larger issue though |
damccorm
commented
Jan 7, 2025
One thing which may help is that the problematic dependency is actually a test-only dependency - beam/sdks/java/io/debezium/build.gradle Line 65 in 4a5575c So worst case, we could probably only force the dependency for testing postgres, but that is definitely not an awesome place to land... |
* Update bom to 26.50.0 * Remove null checks * Update gcs * Bump aws versions
clairemcginty
commented
Feb 25, 2025
hi! I was wondering if there were plans to bump the GrpcVendoring protobuf version to 4.x as well? I also noticed when updating % cs resolve org.apache.beam:beam-sdks-java-extensions-protobuf:2.63.0
args4j:args4j:2.33:default
com.charleskorn.kaml:kaml:0.20.0:default
com.fasterxml.jackson.core:jackson-annotations:2.15.4:default
com.fasterxml.jackson.core:jackson-core:2.16.1:default
com.fasterxml.jackson.core:jackson-databind:2.15.4:default
...
com.google.protobuf:protobuf-java:4.29.0:default
com.google.protobuf:protobuf-java-util:3.25.2:defaultand % cs resolve org.apache.beam:beam-sdks-java-extensions-google-cloud-platform-core:2.63.0
args4j:args4j:2.33:default
com.fasterxml.jackson.core:jackson-annotations:2.15.4:default
com.fasterxml.jackson.core:jackson-core:2.18.0:default
com.fasterxml.jackson.core:jackson-databind:2.15.4:default
...
com.google.protobuf:protobuf-java:3.25.5:default
com.google.protobuf:protobuf-java-util:3.25.5:default |
damccorm
commented
Feb 25, 2025
That dependency comes from https://github.com/grpc/grpc-java/blob/34a7cffcf3dca012cd3e48da14d127c3afd924bf/gradle/libs.versions.toml#L9 so we would either need to wait for a new grpc release or we'd need to override this version (which may have unknown consequences). Because of this setup and the requirements of the Google BOM, historically, we have not kept these versions in sync. 3.25.x is theoretically supposed to have some compatibility guarantees with 4.x so that they can work together, is that specifically giving you problems? |
clairemcginty
commented
Feb 25, 2025
thanks @damccorm! I haven't encountered any specific problems yet -- I was just concerned about compatibility if the GCP libraries BOM is on Protobuf 4 and Beam is mostly on 3. Good to know they're theoretically compatible 👍 |
tkaymak
commented
Apr 24, 2025
The new Debezium 3.1 should have a newer proto version available. Would it now be feasible to upgrade DebeziumIO to use 3.1? (https://debezium.io/releases/3.1/release-notes#other_changes_5 -> https://github.com/debezium/container-images/pull/427/files)? |
This notably includes upgrading protobuf. Changes are segmented by commit:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.