Skip to content

ZetaSQL test Java version fixes - #33213

Merged
Abacn merged 1 commit into
apache:masterfrom
Abacn:zetasqltest
Nov 25, 2024
Merged

ZetaSQL test Java version fixes#33213
Abacn merged 1 commit into
apache:masterfrom
Abacn:zetasqltest

Conversation

@Abacn

Copy link
Copy Markdown
Contributor
  • Align SDK container version with pipeline submission env

  • Disable ZetaSQL test on Java8

This fixes beam_PostCommit_XVR_PythonUsingJavaSQL_Dataflow and beam_PostCommit_XVR_Samza after #32902

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov

codecovBot commented Nov 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.93%. Comparing base (b70375d) to head (6bc6036).
Report is 5 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #33213 +/- ##
============================================
- Coverage 58.93% 58.93% -0.01% 
Complexity 3112 3112 ============================================
Files 1133 1133 Lines 174989 174989 Branches 3343 3343 ============================================
- Hits 103133 103128 -5 - Misses 68507 68512 +5 
Partials 3349 3349 
FlagCoverage Δ
python81.40% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

* Align SDK container version with pipeline submission env
* Disable ZetaSQL test on Java8
@Abacn

Copy link
Copy Markdown
ContributorAuthor

R: @shunping

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@shunpingshunping left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thankl!

@Abacn
Abacn merged commit c0ab7e5 into apache:masterNov 25, 2024
@Abacn
Abacn deleted the zetasqltest branch November 26, 2024 17:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Abacn@shunping