Skip to content

[Dataflow Streaming Appliance] Fix per key commit size validation - #33597

Merged
scwhittle merged 5 commits into
apache:masterfrom
arunpandianp:fixCommitLarge
Jan 17, 2025
Merged

[Dataflow Streaming Appliance] Fix per key commit size validation#33597
scwhittle merged 5 commits into
apache:masterfrom
arunpandianp:fixCommitLarge

Conversation

@arunpandianp

Copy link
Copy Markdown
Contributor

fixes#33588

@arunpandianp

Copy link
Copy Markdown
ContributorAuthor

R: @scwhittle

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@arunpandianp

Copy link
Copy Markdown
ContributorAuthor

Run Java Precommit

@scwhittle
scwhittle merged commit edc4766 into apache:masterJan 17, 2025
@Amar3tto

Copy link
Copy Markdown
Collaborator

This PR broke 5 workflows: #33723, #33722, #33721, #33720, #32224.
Working on the fix.

@Abacn

Copy link
Copy Markdown
Contributor

I'm leaning to revert the change, as this one is supposed to fix some issue but the added test suggest it does not

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: [Dataflow Streaming Appliance] Key commits > 180MB are failing with KeyCommitTooLargeException with beam 2.60.0+

4 participants

@arunpandianp@Amar3tto@Abacn@scwhittle