Skip to content

Add core and missing transformers for yaml integration testing - phase 2sh - #34654

Merged
tvalentyn merged 7 commits into
apache:masterfrom
derrickaw:e2eTopTransformersIntegrationTesting
Apr 22, 2025
Merged

Add core and missing transformers for yaml integration testing - phase 2sh#34654
tvalentyn merged 7 commits into
apache:masterfrom
derrickaw:e2eTopTransformersIntegrationTesting

Conversation

@derrickaw

Copy link
Copy Markdown
Collaborator

Please add a meaningful description for your change here


Fixes#34611

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov

codecovBot commented Apr 17, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.15%. Comparing base (7caa09c) to head (91cdb2c).
Report is 81 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #34654 +/- ##
==========================================
- Coverage 72.31% 72.15% -0.16% 
==========================================
Files 678 732 +54 Lines 99772 109302 +9530 ==========================================
+ Hits 72146 78871 +6725 - Misses 26064 28869 +2805 
Partials 1562 1562 
FlagCoverage Δ
python81.26% <ø> (-1.61%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw
derrickaw marked this pull request as ready for review April 17, 2025 13:38
@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @shunping for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

`cross_product` is set to `true` but only the two rows
`('a', 1)` and `('b', 2)` when it is set to `false`.
Only meaningful (and required) if multiple rows are specified.
error_handling: Whether and how to handle errors during iteration.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this line? It seems the function parameter error_handling is still there.

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting this failure when running with it:
FAILED apache_beam/yaml/integration_tests.py::ExplodeTest::test_Explode_ExternalJavaProvider_WriteToJson_ExternalJavaProvider_3 - ValueError: Error applying transform at line 101: Transform 'beam:schematransform:org.apache.beam:yaml:explode:v1' was configured with unknown fields: {'error_handling'}. Valid fields: {'fields', 'cross_product'}

@derrickawderrickawApr 17, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the error_handling doc string deletion and made another TODO to investigate further in conjunction with the other todo. Thanks!

@shunpingshunping left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a minor comment, but mostly LGTM. Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

R: @tvalentyn for final approval

@derrickaw
derrickawforce-pushed the e2eTopTransformersIntegrationTesting branch from bab6582 to 692d5e7CompareApril 18, 2025 13:18
@derrickaw

derrickaw commented Apr 18, 2025

Copy link
Copy Markdown
CollaboratorAuthor

I think the two failing checks are not related to this PR.

@derrickawderrickaw changed the title Add top transformers for yaml integration testingAdd top transformers for yaml integration testing - phase 2Apr 21, 2025
@derrickawderrickaw changed the title Add top transformers for yaml integration testing - phase 2Add core and missing transformers for yaml integration testing - phase 2shApr 21, 2025
@derrickaw

Copy link
Copy Markdown
CollaboratorAuthor

Run Python_Coverage PreCommit

@derrickaw

Copy link
Copy Markdown
CollaboratorAuthor

Run Python_ML PreCommit 3.10

@tvalentyn

Copy link
Copy Markdown
Contributor

What is the plan to continuously test these yaml examples?

@tvalentyn

Copy link
Copy Markdown
Contributor

nvm, these are test pipelines.

@tvalentyn
tvalentyn merged commit b3c3179 into apache:masterApr 22, 2025
@derrickaw
derrickaw deleted the e2eTopTransformersIntegrationTesting branch April 22, 2025 17:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Improve Yaml Integration test coverage for top 5 transformers missing

3 participants

@derrickaw@tvalentyn@shunping