Yaml IT - Phase 3a

[derrickaw]

Please add a meaningful description for your change here

---

Phase 3 of this document - https://s.apache.org/beam-yaml-it
#34611

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[derrickaw]

Run Python_PVR_Flink PreCommit

[github-actions]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @claudevdm for label python.
R: @Abacn for label java.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[github-actions]

Reminder, please take a look at this pr: @claudevdm@Abacn

[claudevdm]

Theres quite a lot of repetition for setting up all the jdbc compatible databases. Can we simplify it by using SqlAlcemy like in jdbcio tests

beam/sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py

Line 139 in d7fdefe

cls.engines[db_type] =sqlalchemy.create_engine(

?

[derrickaw]

Updated, thanks

[github-actions]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.
R: @robertwb for label java.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

[damccorm]

waiting on author

[derrickaw]

Run Java Precommit

[derrickaw]

Seems like these failures are not related to this PR.

[damccorm]

Thanks - had one minor question, otherwise LGTM

[damccorm]

Should this be a testImplementation? Why do we need this?

[derrickaw]

1. My understanding is that testImplementation is for tests inside the schemaio-expansion-service module. We need the runtimeOnly so that its packaged in the jar for use later.
2. It contains the driver for connecting to the DB.

[damccorm]

Ok, that makes sense. I think the thing we're doing here is not really a test change FWIW, it is enabling JDBCIO to connect to a new kind of DB (this is exposing a new feature in x-lang mode).

I think this is ok since we are already packaging other drivers (e.g. com.microsoft.sqlserver:mssql-jdbc:12.2.0.jre11). The only real concern I would have is the size of the jar, which seems fine.

[shunping]

Any update on this?

[damccorm]

Failures seem like flakes, so rerunning. If they pass, I will merge