Uh oh!
There was an error while loading. Please reload this page.
[BEAM-286] Reorganize flink runner module to follow other runners str… - #348
[BEAM-286] Reorganize flink runner module to follow other runners str…#348jbonofre wants to merge 1 commit into
Conversation
jbonofre
commented
May 18, 2016
aljoscha
commented
May 18, 2016
Since this is mostly touching POMs and removing examples it shouldn't clash to much with #343. You'll probably have to coordinate with with @jasonkuster on #345. LGTM to me, since it's mostly removing examples that were originally copied from the Google Dataflow (not a mistake) code base. Let's wait and see what @mxm has to say. |
jasonkuster
commented
May 18, 2016
Looks like this is a superset of the flink stuff I'm doing in #345. Since this makes more changes, I'm happy to revert the flink changes I've made, wait for this to go in, and then rebase to pick this up. |
jbonofre
commented
May 20, 2016
@aljoscha Thanks for the update. |
mxm
commented
May 20, 2016
I commented on the JIRA issue. I don't think we can merge this PR. However, we could get rid of some of the examples in a separate issue/pull request. |
davorbonaci
commented
May 23, 2016
Triage: 0.1.0-incubating, release blocking. Let's continue the discussion in JIRA. |
jbonofre
commented
Jul 14, 2016
For now, I'm closing this PR. |
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
Reorganize flink runner module to follow other runners structure.