Skip to content

Fix for issue 34772 to include user provided providers - #35033

Merged
shunping merged 3 commits into
apache:masterfrom
Bhargavkonidena:fix_34772
Jun 2, 2025
Merged

Fix for issue 34772 to include user provided providers#35033
shunping merged 3 commits into
apache:masterfrom
Bhargavkonidena:fix_34772

Conversation

@Bhargavkonidena

@BhargavkonidenaBhargavkonidena commented May 23, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Addresses #34772 by adding code changes to consider user provided providers if they are provided via command-line arguments.

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions

github-actionsBot commented May 23, 2025

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions

github-actionsBot commented May 24, 2025

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @shunping for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Bhargavkonidena

Bhargavkonidena commented May 25, 2025

Copy link
Copy Markdown
ContributorAuthor

assign set of reviewers

@github-actions

github-actionsBot commented May 25, 2025

Copy link
Copy Markdown
Contributor

Reviewers are already assigned to this PR: @shunping

@Bhargavkonidena

Bhargavkonidena commented May 30, 2025

Copy link
Copy Markdown
ContributorAuthor

@shunping Can you please review this PR.

shunping
shunping requested changes May 30, 2025
View reviewed changes
Comment threadsdks/python/apache_beam/yaml/generate_yaml_docs.py Outdated
@shunping

shunping commented May 30, 2025

Copy link
Copy Markdown
Collaborator

@shunping Can you please review this PR.

Yes. It looks good overall, but to make things consistent, please correct the flag name. Thanks!

@shunping

shunping commented May 31, 2025

Copy link
Copy Markdown
Collaborator

remind me after tests pass

@github-actions

github-actionsBot commented May 31, 2025

Copy link
Copy Markdown
Contributor

Ok - I'll remind @shunping after tests pass

@Bhargavkonidena

Bhargavkonidena commented Jun 2, 2025

Copy link
Copy Markdown
ContributorAuthor

@shunping can you please check now?

shunping
shunping approved these changes Jun 2, 2025
View reviewed changes

@shunpingshunping left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shunping
shunping merged commit b69f23f into apache:masterJun 2, 2025
shunping pushed a commit to shunping/beam that referenced this pull request Jun 6, 2025
@Bhargavkonidena@shunping
Fix for issue 34772 to include user provided providers (apache#35033)
eda379d
* Fix for issue 34772 to include user provided providers
* Fix CI checks
* Incorporate review comments
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shunpingshunpingshunping approved these changes

Assignees

No one assigned

Labels

Next Action: Reviewerspythonyaml

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bhargavkonidena@shunping