Uh oh!
There was an error while loading. Please reload this page.
Prism: Fix event-time timer firing earlier than the time set. - #35089
Merged
liferoad merged 2 commits intoMay 30, 2025
Conversation
shunpingforce-pushed
the
prism-fix-event-timer-early-firing
branch
from
May 30, 2025 03:24
89e9b4f to
2cd7e70Compareshunping
marked this pull request as ready for review
May 30, 2025 04:05
Contributor
Assigning reviewers: R: @jrmccluskey for label go. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Uh oh!
There was an error while loading. Please reload this page.
lostluck
approved these changes
May 30, 2025
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#35090.
Running the same test code from #35090 (comment), we no longer see timer callback being invoked.
Furthermore, if we change the test code to set firing timestamp of a timer to be the timestamp of first element + 2 (rather than 10 in the original test), we will see the timer callback is actually called.