Uh oh!
There was an error while loading. Please reload this page.
[DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch - #35271
[DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch#35271Amar3tto wants to merge 1 commit into
Conversation
Test Results15 tests 15 ✅ 1h 46m 28s ⏱️ Results for commit f1935a7. |
Assigning reviewers: R: @damccorm for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Amar3tto
commented
Jun 16, 2025
@ahmedabu98 Could you please take a look at the failed Iceberg checks? |
ahmedabu98
commented
Jun 16, 2025
@Amar3tto I checked the Dataflow pipelines. The tests on master are pulling the SDK container image from Dataflow tests on this PR are pulling from The difference reflects this change: 086ae6c My guess is the Dataflow container just hasn't been built and uploaded to that location yet |
damccorm
commented
Jun 16, 2025
Yes, see - https://github.com/apache/beam/blob/master/contributor-docs/release-guide.md#verify-release-branch "NOTE Dataflow tests will fail if the Dataflow worker container is not created and published by this time. Should be done by Google, in response to the creation of the release branch, and docker images are hosted. This should not block creation of the first release candidate, but should block approval of the release." |
damccorm
commented
Jun 16, 2025
@Amar3tto I'd recommend that you go ahead and create the first RC. At that point, I can publish the Dataflow containers needed to make this pass. |
ahmedabu98
commented
Jun 16, 2025
Hmmm I see that the other Dataflow tests are passing because they first build and publish a new container image to use for the test, e.g.: beam/runners/google-cloud-dataflow-java/build.gradle Lines 712 to 714 in 19ff1df Iceberg Dataflow tests are missing this step. |
ahmedabu98
commented
Jun 16, 2025
Adding it in #35307 |
Reminder, please take a look at this pr: @damccorm |
damccorm
commented
Jun 24, 2025
stop reviewer notifications |
Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment |
Tests run on GHA should be queued shortly.