Skip to content

[Beam SQL] Change SET CATALOG to USE CATALOG - #35314

Merged
ahmedabu98 merged 2 commits into
apache:masterfrom
ahmedabu98:ice_sql_use_catalog
Jun 17, 2025
Merged

[Beam SQL] Change SET CATALOG to USE CATALOG#35314
ahmedabu98 merged 2 commits into
apache:masterfrom
ahmedabu98:ice_sql_use_catalog

Conversation

@ahmedabu98

@ahmedabu98ahmedabu98 commented Jun 16, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Modifying the syntax introduced in #35223

@ahmedabu98ahmedabu98 added this to the 2.66.0 Release milestone Jun 16, 2025
@ahmedabu98

ahmedabu98 commented Jun 16, 2025

Copy link
Copy Markdown
ContributorAuthor

@Amar3tto we have a change we'd like to get in before releasing the new SQL syntax

@github-actions

github-actionsBot commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@ahmedabu98

ahmedabu98 commented Jun 17, 2025

Copy link
Copy Markdown
ContributorAuthor

Errors in Precommit SQL workflows are due to new warnings surfacing after the SpotBugs upgrade in #35303

The actual unit tests and integration tests are passing though

@ahmedabu98

ahmedabu98 commented Jun 17, 2025

Copy link
Copy Markdown
ContributorAuthor

R: @kennknowles
CC @je-ik

@github-actions

github-actionsBot commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@ahmedabu98

ahmedabu98 commented Jun 17, 2025

Copy link
Copy Markdown
ContributorAuthor

CC @talatuyarer

talatuyarer
talatuyarer approved these changes Jun 17, 2025
View reviewed changes

@talatuyarertalatuyarer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for aligning with general usage @ahmedabu98

@ahmedabu98
ahmedabu98 merged commit 0e4b2a3 into apache:masterJun 17, 2025
ahmedabu98 added a commit to ahmedabu98/beam that referenced this pull request Jun 17, 2025
@ahmedabu98
[Beam SQL] Change SET CATALOG to USE CATALOG (apache#35314)
bfbe8a1
* USE catalog instead of SET
* add missing
This was referenced Jun 17, 2025
Merged
Merged
ahmedabu98 added a commit to ahmedabu98/beam that referenced this pull request Jun 17, 2025
@ahmedabu98
[Beam SQL] Change SET CATALOG to USE CATALOG (apache#35314)
8c55ac6
* USE catalog instead of SET
* add missing
@ahmedabu98ahmedabu98 mentioned this pull request Jun 17, 2025
Closed
ahmedabu98 added a commit that referenced this pull request Jun 17, 2025
@ahmedabu98
[Beam SQL] Change SET CATALOG to USE CATALOG (#35314) (#35333)
7d610f8
* USE catalog instead of SET
* add missing
Amar3tto added a commit that referenced this pull request Jul 14, 2025
@Amar3tto
Revert#35314
70aa86b
@Amar3ttoAmar3tto mentioned this pull request Jul 14, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennknowleskennknowleskennknowles approved these changes
+1 more reviewer
@talatuyarertalatuyarertalatuyarer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

extensionsjavasql

Projects

None yet

Milestone

2.66.0 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@ahmedabu98@kennknowles@talatuyarer