Uh oh!
There was an error while loading. Please reload this page.
[yaml]: Phases 3-4 Moderate-High Usage Yaml examples - #35423
Merged
Merged
Conversation
Contributor
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
claudevdm
approved these changes
Jun 26, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
R: @jrmccluskey for final approval |
derrickaw
commented
Jun 27, 2025
CollaboratorAuthor
Failures don't seem related to these changes. |
jrmccluskey
approved these changes
Jun 27, 2025
jrmccluskey
left a comment
Contributor
There was a problem hiding this comment.
LGTM, going to give the red test suites one more spin but I do not think those failures are related here
jrmccluskey
commented
Jun 27, 2025
Contributor
Looks like the linting problem is in Vertex AI text embeddings, putting a fix out in #35461. Merging this here. |
jrmccluskey pushed a commit
to jrmccluskey/beam
that referenced
this pull request
Jul 1, 2025
* rebase * update infra and input data to current * add phases 3-4 examples * remove other PR code * remove other pubsub previous pr code * add streaming option * similfy code from previous PR into these code changes * address comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#35030 - Phases 3-4
Left to do:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.