Uh oh!
There was an error while loading. Please reload this page.
[IcebergIO] Create tables with Iceberg Table Properties - #35496
Merged
Conversation
tarun-googleforce-pushed
the
iceberg_table_properties
branch
from
July 1, 2025 18:20
45ed005 to
c561272Comparetarun-googleforce-pushed
the
iceberg_table_properties
branch
from
July 1, 2025 18:24
c561272 to
a7b77adCompare
ahmedabu98
left a comment
Contributor
There was a problem hiding this comment.
Thanks @tarun-google, this looks great! just one comment
Uh oh!
There was an error while loading. Please reload this page.
ahmedabu98
commented
Jul 1, 2025
Contributor
Also no need to manually update the docs, just run |
tarun-google
marked this pull request as ready for review
July 1, 2025 19:39
Contributor
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
tarun-googleforce-pushed
the
iceberg_table_properties
branch
from
July 1, 2025 20:49
0efb25b to
5458a46Comparetarun-google
commented
Jul 1, 2025
ContributorAuthor
"Run Java PreCommit" |
tarun-google
commented
Jul 1, 2025
ContributorAuthor
Run Java PreCommit |
ahmedabu98
commented
Jul 2, 2025
Contributor
Congrats on your first PR @tarun-google! |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Fixes issue #34966
Allows users to pass Iceberg Table properties which are used while creating a table. For more information on table properties please visit https://iceberg.apache.org/docs/latest/configuration/#table-properties
This PR only addresses providing table-properties through beam-sdks-java-io-iceberg. It does not handle providing properties through Beam SQL