Skip to content

[IcebergIO] Create tables with Iceberg Table Properties - #35496

Merged
ahmedabu98 merged 5 commits into
apache:masterfrom
tarun-google:iceberg_table_properties
Jul 2, 2025
Merged

[IcebergIO] Create tables with Iceberg Table Properties#35496
ahmedabu98 merged 5 commits into
apache:masterfrom
tarun-google:iceberg_table_properties

Conversation

@tarun-google

@tarun-googletarun-google commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

This PR Fixes issue #34966

Allows users to pass Iceberg Table properties which are used while creating a table. For more information on table properties please visit https://iceberg.apache.org/docs/latest/configuration/#table-properties

This PR only addresses providing table-properties through beam-sdks-java-io-iceberg. It does not handle providing properties through Beam SQL

@tarun-google
tarun-googleforce-pushed the iceberg_table_properties branch from c561272 to a7b77adCompareJuly 1, 2025 18:24
@tarun-googletarun-google changed the title [IcebergIO] Create tables with a Iceberg Table Properties[IcebergIO] Create tables with Iceberg Table PropertiesJul 1, 2025

@ahmedabu98ahmedabu98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tarun-google, this looks great! just one comment

@ahmedabu98

Copy link
Copy Markdown
Contributor

Also no need to manually update the docs, just run ./gradlew generateExternalTransformsConfig and it will generate it with appropriate styling.

@tarun-google
tarun-google marked this pull request as ready for review July 1, 2025 19:39
@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@tarun-google
tarun-googleforce-pushed the iceberg_table_properties branch from 0efb25b to 5458a46CompareJuly 1, 2025 20:49
@tarun-google

Copy link
Copy Markdown
ContributorAuthor

"Run Java PreCommit"

@tarun-google

Copy link
Copy Markdown
ContributorAuthor

Run Java PreCommit

@ahmedabu98ahmedabu98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahmedabu98

Copy link
Copy Markdown
Contributor

Congrats on your first PR @tarun-google!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tarun-google@ahmedabu98