Uh oh!
There was an error while loading. Please reload this page.
[Beam SQL] Support DATABASE concept in Beam SQL, with implementation for Iceberg - #35641
Conversation
ahmedabu98
commented
Jul 21, 2025
cc @talatuyarer |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
ahmedabu98
commented
Jul 21, 2025
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Uh oh!
There was an error while loading. Please reload this page.
tarun-google
left a comment
There was a problem hiding this comment.
LGTM !! Great work fixing gap in Iceberg Beam SQL
Uh oh!
There was an error while loading. Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #35641 +/- ##
=========================================
Coverage 56.54% 56.54% Complexity 3382 3382 =========================================
Files 1205 1205 Lines 183856 183856 Branches 3477 3477 =========================================
Hits 103961 103961 Misses 76577 76577 Partials 3318 3318 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Addresses #35637
These changes allow the following:
CREATE DATABASE ( IF NOT EXISTS )? database_nameUSE DATABASE database_nameDROP DATABASE [ IF EXISTS ] database_name [ RESTRICT | CASCADE ]RESTRICT(default) will throw an error if the database contains a table.CASCADEwill drop all tables within the database before dropping the database.For Iceberg catalogs,
CREATEandDROPwill create/drop real external tables in the appropriate data platform.These implementations will help bring Beam closer to alignment with existing Flink and Spark syntax