Uh oh!
There was an error while loading. Please reload this page.
workflows: add ubuntu-latest to beam_PreCommit_Python_ML, beam_PostCommit_Python, and beam_PreCommit_Python_Coverage - #35816
Conversation
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
moawnallah
commented
Aug 7, 2025
cc @damccorm |
damccorm
commented
Aug 7, 2025
Thanks! I copied your changes and am running a couple of test runs to try them out: |
Assigning reviewers: R: @damccorm for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
commented
Aug 7, 2025
Some things failed, but it may just be flakes. The Python Postcommit workflow seems to be broken anyways |
The precommit ml tests failing are currently the ones running on |
damccorm
commented
Aug 8, 2025
There is good news and bad news. The bad news is that the new docker_in_docker jobs failed. The good news is that they failed in an expected/positive way - they returned exit code 5 which means no tests were run. Since no tests actually have the |
Nice!
I merged the change of upstream beam master branch in this PR #35577 to be reviewable state. With this PR we would have require_docker_in_docker marked as well +1 for making milvus as extra dependency. Will invite for a look after the relevant CI tests pass |
Uh oh!
There was an error while loading. Please reload this page.
damccorm
commented
Aug 15, 2025
Testing this against latest master: |
77dc18b to
bd56d2cCompare
This seems promising. There are no Postcommit failures and other precommits ml python variant versions seems not related |
I found some issues in the CI due to milvus extra dependency not added properly. Submitted commit to fix this |
We can trigger those workflows again after properly making milvus as extra dependency EDIT: |
ubuntu-latest to beam_PreCommit_Python_ML and beam_PostCommit_Pythonubuntu-latest to beam_PreCommit_Python_ML, beam_PostCommit_Python, and beam_PreCommit_Python_Coveragemoawnallah
commented
Aug 28, 2025
Hey @damccorm, I've merged the latest changes from master branch and added |
damccorm
commented
Aug 29, 2025
Yes, running here:
|
damccorm
commented
Aug 29, 2025
Looks like the precommit ML workflow failed and so did the postcommit python workflow. The precommit ML workflow at least seems to be an error related to tfx - https://stackoverflow.com/questions/77972546/pip-vendor-resolvelib-resolvers-resolutiontoodeep-200000 Could you try updating pip as part of the workflow? I'll also note that you should be able to at least run the precommit ML workflow on your fork to test for correctness, would you mind trying that? |
moawnallah
commented
Aug 29, 2025
Added that commit c8d88b0 that would upgrade pip in precommit ML workflow and this is the PR on my fork: |
damccorm
commented
Sep 5, 2025
Sorry, I lost track of this PR. It looks like all of the runs on your PR got cancelled, not sure why, but I'm running the relevant workflows now:
|
@damccorm – have just removed |
damccorm
commented
Sep 5, 2025
Sure, kicking off now:
|
moawnallah
commented
Sep 7, 2025
Precommit ML currently failing on python versions < 3.12 with |
damccorm
commented
Sep 8, 2025
This sounds good to me. Kicking off another set of runs: Postcommit python - https://github.com/apache/beam/actions/runs/17553439850 |
The relevant tests are passing with the changeset in this PR 👍 PS:
|
moawnallah
commented
Sep 9, 2025
@damccorm - this PR seems ready for merge as well given the changes pass in the relevant workflows? |
damccorm
commented
Sep 9, 2025
I agree that the bigtable failures seem unrelated/unconcerning. The other ones seem more like real problems that we should deal with (probably in other prs) before merging this one. I don't think we should merge here until we're confident that workflows will be green (otherwise this will create work for others) |
Sounds good and thoughtful. Perhaps waiting after this PR #35473 is merged hopefully no longer be issues on postcommit regards cloudsql tests 👍 Regards milvus tests they aren't supposed to running on postcommit python workflow given they are already marked with beam/sdks/python/apache_beam/ml/rag/enrichment/milvus_search_it_test.py Lines 472 to 480 in 10f0f07 beam/.github/workflows/beam_PostCommit_Python.yml Lines 109 to 113 in 10f0f07 |
@damccorm you are right. Milvus tests failure turned actually to be real problem. It turns out the issue forgetting removing Regards CloudSQL tests given that PR #35473 is merged (also merged the latest changes here). They are expected not to run in the postcommits so no issues supposed to happen regards them in PostCommit python workflow Can we trigger the workflows again (similar to #35816 (comment)) with those changes to make sure no regressions? |
damccorm
commented
Sep 12, 2025
Triggered! Postcommit python - https://github.com/apache/beam/actions/runs/17676270810 |
damccorm
commented
Sep 12, 2025
Hm, the postcommit failures look like they may be related to the last pr - 1da37bc#diff-ebd8674386d314aac76d74aaec08bc2fc23427577e3021ce5014c080c4939ca9 I see I think this PR is fine, so we can merge here for now |
Uh oh!
There was an error while loading. Please reload this page.
@damccorm – In this PR #35473 and current one we haven't touched the bigtable enrichment code just the CloudSQL enrichment code. I have also checked the logs in the PostCommit workflows run (https://github.com/apache/beam/actions/runs/17676270810/job/50239024594) cloudSQL tests wasn't running and that is expected $ cat "job-logs-python-3.9.txt"| grep "cloudsql"
2025-09-12T13:48:40.6195331Z #9 153.4 INFO:root:copying apache_beam/transforms/enrichment_handlers/cloudsql.py -> build/lib.linux-x86_64-cpython-39/apache_beam/transforms/enrichment_handlers
2025-09-12T13:48:40.6197152Z #9 153.4 INFO:root:copying apache_beam/transforms/enrichment_handlers/cloudsql_it_test.py -> build/lib.linux-x86_64-cpython-39/apache_beam/transforms/enrichment_handlers
2025-09-12T13:48:40.6201888Z #9 153.4 INFO:root:copying apache_beam/transforms/enrichment_handlers/cloudsql_test.py -> build/lib.linux-x86_64-cpython-39/apache_beam/transforms/enrichment_handlers
2025-09-12T13:48:40.6995855Z #9 153.5 INFO:root:copying apache_beam/ml/rag/ingestion/cloudsql.py -> build/lib.linux-x86_64-cpython-39/apache_beam/ml/rag/ingestion
2025-09-12T13:48:40.6996190Z #9 153.5 INFO:root:copying apache_beam/ml/rag/ingestion/cloudsql_it_test.py -> build/lib.linux-x86_64-cpython-39/apache_beam/ml/rag/ingestion
2025-09-12T13:51:13.3258607Z #9 306.1 INFO:root:copying build/lib.linux-x86_64-cpython-39/apache_beam/transforms/enrichment_handlers/cloudsql.py -> build/bdist.linux-x86_64/wheel/./apache_beam/transforms/enrichment_handlers
2025-09-12T13:51:13.3260727Z #9 306.1 INFO:root:copying build/lib.linux-x86_64-cpython-39/apache_beam/transforms/enrichment_handlers/cloudsql_it_test.py -> build/bdist.linux-x86_64/wheel/./apache_beam/transforms/enrichment_handlers
2025-09-12T13:51:13.3266127Z #9 306.1 INFO:root:copying build/lib.linux-x86_64-cpython-39/apache_beam/transforms/enrichment_handlers/cloudsql_test.py -> build/bdist.linux-x86_64/wheel/./apache_beam/transforms/enrichment_handlers
2025-09-12T13:51:13.4147035Z #9 306.2 INFO:root:copying build/lib.linux-x86_64-cpython-39/apache_beam/ml/rag/ingestion/cloudsql.py -> build/bdist.linux-x86_64/wheel/./apache_beam/ml/rag/ingestion
2025-09-12T13:51:13.4147442Z #9 306.2 INFO:root:copying build/lib.linux-x86_64-cpython-39/apache_beam/ml/rag/ingestion/cloudsql_it_test.py -> build/bdist.linux-x86_64/wheel/./apache_beam/ml/rag/ingestion
2025-09-12T13:51:14.6732152Z #9 307.4 INFO:wheel:adding 'apache_beam/ml/rag/ingestion/cloudsql.py'
2025-09-12T13:51:14.6732532Z #9 307.4 INFO:wheel:adding 'apache_beam/ml/rag/ingestion/cloudsql_it_test.py'
2025-09-12T13:51:15.7710474Z #9 308.5 INFO:wheel:adding 'apache_beam/transforms/enrichment_handlers/cloudsql.py'
2025-09-12T13:51:15.7710925Z #9 308.5 INFO:wheel:adding 'apache_beam/transforms/enrichment_handlers/cloudsql_it_test.py'
2025-09-12T13:51:15.7711400Z #9 308.5 INFO:wheel:adding 'apache_beam/transforms/enrichment_handlers/cloudsql_test.py'$ cat "job-logs-python-3.10.txt"| grep "cloudsql"
2025-09-12T13:48:58.9028997Z #9 122.9 INFO:root:copying apache_beam/transforms/enrichment_handlers/cloudsql.py -> build/lib.linux-x86_64-cpython-310/apache_beam/transforms/enrichment_handlers
2025-09-12T13:48:58.9030871Z #9 122.9 INFO:root:copying apache_beam/transforms/enrichment_handlers/cloudsql_it_test.py -> build/lib.linux-x86_64-cpython-310/apache_beam/transforms/enrichment_handlers
2025-09-12T13:48:58.9035431Z #9 122.9 INFO:root:copying apache_beam/transforms/enrichment_handlers/cloudsql_test.py -> build/lib.linux-x86_64-cpython-310/apache_beam/transforms/enrichment_handlers
2025-09-12T13:48:58.9554468Z #9 123.3 INFO:root:copying apache_beam/ml/rag/ingestion/cloudsql.py -> build/lib.linux-x86_64-cpython-310/apache_beam/ml/rag/ingestion
2025-09-12T13:48:58.9555197Z #9 123.3 INFO:root:copying apache_beam/ml/rag/ingestion/cloudsql_it_test.py -> build/lib.linux-x86_64-cpython-310/apache_beam/ml/rag/ingestion
2025-09-12T13:51:40.6986079Z #9 304.7 INFO:root:copying build/lib.linux-x86_64-cpython-310/apache_beam/transforms/enrichment_handlers/cloudsql.py -> build/bdist.linux-x86_64/wheel/./apache_beam/transforms/enrichment_handlers
2025-09-12T13:51:40.6989720Z #9 304.7 INFO:root:copying build/lib.linux-x86_64-cpython-310/apache_beam/transforms/enrichment_handlers/cloudsql_it_test.py -> build/bdist.linux-x86_64/wheel/./apache_beam/transforms/enrichment_handlers
2025-09-12T13:51:40.6997091Z #9 304.7 INFO:root:copying build/lib.linux-x86_64-cpython-310/apache_beam/transforms/enrichment_handlers/cloudsql_test.py -> build/bdist.linux-x86_64/wheel/./apache_beam/transforms/enrichment_handlers
2025-09-12T13:51:40.7944543Z #9 304.8 INFO:root:copying build/lib.linux-x86_64-cpython-310/apache_beam/ml/rag/ingestion/cloudsql.py -> build/bdist.linux-x86_64/wheel/./apache_beam/ml/rag/ingestion
2025-09-12T13:51:40.7945462Z #9 304.8 INFO:root:copying build/lib.linux-x86_64-cpython-310/apache_beam/ml/rag/ingestion/cloudsql_it_test.py -> build/bdist.linux-x86_64/wheel/./apache_beam/ml/rag/ingestion
2025-09-12T13:51:41.9564684Z #9 305.9 INFO:wheel:adding 'apache_beam/ml/rag/ingestion/cloudsql.py'
2025-09-12T13:51:41.9565338Z #9 305.9 INFO:wheel:adding 'apache_beam/ml/rag/ingestion/cloudsql_it_test.py'
2025-09-12T13:51:43.1498356Z #9 307.1 INFO:wheel:adding 'apache_beam/transforms/enrichment_handlers/cloudsql.py'
2025-09-12T13:51:43.1498837Z #9 307.1 INFO:wheel:adding 'apache_beam/transforms/enrichment_handlers/cloudsql_it_test.py'
2025-09-12T13:51:43.1499331Z #9 307.1 INFO:wheel:adding 'apache_beam/transforms/enrichment_handlers/cloudsql_test.py'$ cat "job-logs-python-3.11.txt"| grep "cloudsql"
2025-09-12T13:48:55.9911738Z #9 140.9 INFO:root:copying apache_beam/transforms/enrichment_handlers/cloudsql.py -> build/lib.linux-x86_64-cpython-311/apache_beam/transforms/enrichment_handlers
2025-09-12T13:48:55.9913728Z #9 140.9 INFO:root:copying apache_beam/transforms/enrichment_handlers/cloudsql_it_test.py -> build/lib.linux-x86_64-cpython-311/apache_beam/transforms/enrichment_handlers
2025-09-12T13:48:55.9918358Z #9 140.9 INFO:root:copying apache_beam/transforms/enrichment_handlers/cloudsql_test.py -> build/lib.linux-x86_64-cpython-311/apache_beam/transforms/enrichment_handlers
2025-09-12T13:48:56.1628991Z #9 140.9 INFO:root:copying apache_beam/ml/rag/ingestion/cloudsql.py -> build/lib.linux-x86_64-cpython-311/apache_beam/ml/rag/ingestion
2025-09-12T13:48:56.1629697Z #9 140.9 INFO:root:copying apache_beam/ml/rag/ingestion/cloudsql_it_test.py -> build/lib.linux-x86_64-cpython-311/apache_beam/ml/rag/ingestion
2025-09-12T13:51:56.8935772Z #9 298.1 INFO:root:copying build/lib.linux-x86_64-cpython-311/apache_beam/transforms/enrichment_handlers/cloudsql.py -> build/bdist.linux-x86_64/wheel/./apache_beam/transforms/enrichment_handlers
2025-09-12T13:51:56.8937888Z #9 298.1 INFO:root:copying build/lib.linux-x86_64-cpython-311/apache_beam/transforms/enrichment_handlers/cloudsql_it_test.py -> build/bdist.linux-x86_64/wheel/./apache_beam/transforms/enrichment_handlers
2025-09-12T13:51:56.8943917Z #9 298.1 INFO:root:copying build/lib.linux-x86_64-cpython-311/apache_beam/transforms/enrichment_handlers/cloudsql_test.py -> build/bdist.linux-x86_64/wheel/./apache_beam/transforms/enrichment_handlers
2025-09-12T13:51:56.9648710Z #9 298.2 INFO:root:copying build/lib.linux-x86_64-cpython-311/apache_beam/ml/rag/ingestion/cloudsql.py -> build/bdist.linux-x86_64/wheel/./apache_beam/ml/rag/ingestion
2025-09-12T13:51:56.9649138Z #9 298.2 INFO:root:copying build/lib.linux-x86_64-cpython-311/apache_beam/ml/rag/ingestion/cloudsql_it_test.py -> build/bdist.linux-x86_64/wheel/./apache_beam/ml/rag/ingestion
2025-09-12T13:51:56.9959580Z #9 299.2 INFO:wheel:adding 'apache_beam/ml/rag/ingestion/cloudsql.py'
2025-09-12T13:51:56.9959790Z #9 299.2 INFO:wheel:adding 'apache_beam/ml/rag/ingestion/cloudsql_it_test.py'
2025-09-12T13:51:57.0100949Z #9 300.3 INFO:wheel:adding 'apache_beam/transforms/enrichment_handlers/cloudsql.py'
2025-09-12T13:51:57.0101317Z #9 300.3 INFO:wheel:adding 'apache_beam/transforms/enrichment_handlers/cloudsql_it_test.py'
2025-09-12T13:51:57.0101664Z #9 300.3 INFO:wheel:adding 'apache_beam/transforms/enrichment_handlers/cloudsql_test.py' |
Description
In this PR, we add
ubuntu-latesttobeam_PreCommit_Python_ML,beam_PostCommit_Python, andbeam_PreCommit_Python_Coverageworkflows. Currently some tests (e.g Milvus tests) have issues running on self-hosted env due to docker_in_docker env limitation.Dependency for #35577.
Motivation and Context
This change was removed in #35734 due to overlapping issues with pytest markers so it wasn't clear what was the issue actually. With this experimental change we will have more clarity what the issues are of adding
ubuntu-latestto those workflows (if any).Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.