Skip to content

[Elasticsearch] Add support for v9.x - #36670

Merged
Abacn merged 5 commits into
apache:masterfrom
egalpin:egalpin/36491-add-elasticsearch-v9-support
Dec 3, 2025
Merged

[Elasticsearch] Add support for v9.x#36670
Abacn merged 5 commits into
apache:masterfrom
egalpin:egalpin/36491-add-elasticsearch-v9-support

Conversation

@egalpin

@egalpinegalpin commented Oct 29, 2025

Copy link
Copy Markdown
Member

Fixes#36491 by adding support for Elasticsearch v9.x


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@egalpin
egalpinforce-pushed the egalpin/36491-add-elasticsearch-v9-support branch from 750daa9 to 16baed4CompareOctober 29, 2025 22:03
@egalpinegalpin changed the title WIP - copy-pasta v9.x tests as a starting point[Elasticsearch] Add support for v9.xNov 13, 2025
@egalpin
egalpin marked this pull request as ready for review November 13, 2025 19:27
@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @m-trieu for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@egalpin

Copy link
Copy Markdown
MemberAuthor

@m-trieu Any guidance on how to execute the Elasticsearch unit tests? I took a quick look over https://github.com/apache/beam/blob/master/.github/workflows/README.md but I'm not yet clear on how to execute the unit tests for ES

@github-actions

Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @m-trieu

@github-actions

Copy link
Copy Markdown
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@Abacn

Copy link
Copy Markdown
Contributor

Ran ./gradlew :sdks:java:io:elasticsearch-tests:elasticsearch-tests-9:build locally and there is one test failure

testValidSSLAndUsernameConfiguration
java.lang.NullPointerException
at org.apache.beam.sdk.io.elasticsearch.ElasticsearchIOTest.testValidSSLAndUsernameConfiguration(ElasticsearchIOTest.java:303)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

also need to add the test target to github action script

:sdks:java:io:elasticsearch-tests:elasticsearch-tests-common:build \

@github-actionsgithub-actionsBot added build and removed build labels Dec 2, 2025
@egalpin

Copy link
Copy Markdown
MemberAuthor

@Abacn thanks! Both should now be fixed

@github-actionsgithub-actionsBot added build and removed build labels Dec 2, 2025

@AbacnAbacn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM

We may add an annoucement to CHANGES.md, either in this PR or as a follow up

* (Java) Elasticsearch 9 Support for ElasticsearchIO ([#36491](https://github.com/apache/beam/issues/36491)).

* Support for X source added (Java/Python) ([#X](https://github.com/apache/beam/issues/X)).

@egalpin

Copy link
Copy Markdown
MemberAuthor

Good call @Abacn, added!

@Abacn
Abacn merged commit 67d5477 into apache:masterDec 3, 2025
24 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Elasticsearch 9 support

2 participants

@egalpin@Abacn